Bug 84640 - [V8] Fix issue with trying to access a constructor in a frame that has been removed
Summary: [V8] Fix issue with trying to access a constructor in a frame that has been r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 15:17 PDT by Erik Arvidsson
Modified: 2012-04-23 20:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.81 KB, patch)
2012-04-23 15:20 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-04-23 15:17:24 PDT
[V8] Fix issue with trying to access a constructor in a frame that has been removed
Comment 1 Erik Arvidsson 2012-04-23 15:20:39 PDT
Created attachment 138436 [details]
Patch
Comment 3 Kentaro Hara 2012-04-23 15:29:25 PDT
Comment on attachment 138436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review

> LayoutTests/fast/dom/constructor-in-removed-frame.html:17
> +            frame.Window;

Shall we check the value of frame.Window?
Comment 4 Erik Arvidsson 2012-04-23 15:41:24 PDT
(In reply to comment #3)
> (From update of attachment 138436 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review
> 
> > LayoutTests/fast/dom/constructor-in-removed-frame.html:17
> > +            frame.Window;
> 
> Shall we check the value of frame.Window?

We could but V8 and JSC report different values.

V8 returns undefined. JSC returns the Window constructor. V8 matches Firefox and Opera. IE throws access denied.

Based on that I don't think we should check the actual value.
Comment 5 Kentaro Hara 2012-04-23 15:43:07 PDT
Comment on attachment 138436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review

>>> LayoutTests/fast/dom/constructor-in-removed-frame.html:17
>>> +            frame.Window;
>> 
>> Shall we check the value of frame.Window?
> 
> We could but V8 and JSC report different values.
> 
> V8 returns undefined. JSC returns the Window constructor. V8 matches Firefox and Opera. IE throws access denied.
> 
> Based on that I don't think we should check the actual value.

Sounds reasonable.
Comment 6 WebKit Review Bot 2012-04-23 20:22:06 PDT
Comment on attachment 138436 [details]
Patch

Clearing flags on attachment: 138436

Committed r114989: <http://trac.webkit.org/changeset/114989>
Comment 7 WebKit Review Bot 2012-04-23 20:22:11 PDT
All reviewed patches have been landed.  Closing bug.