Bug 84637 - [V8][Refactoring] throwTypeError() should take one string argument that explains what the type error is
Summary: [V8][Refactoring] throwTypeError() should take one string argument that expla...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-04-23 14:46 PDT by Kentaro Hara
Modified: 2012-04-24 10:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.78 KB, patch)
2012-04-23 15:47 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-23 14:46:41 PDT 
Current behavior:
- throwError("foo", V8Proxy::TypeError) is equivalent to throwError("foo")
- throwTypeError() is equivalent to throwError("Type Error")

We want to unify them as follows:

(1) throwTypeError() should take one string argument which explains what the type error is. Just "Type Error" is not descriptive.
(2) Replace all throwError("foo") with throwTypeError("foo").
(3) Replace all throwError("foo", V8Proxy::TypeError) with throwTypeError("foo").

Consequently, only throwTypeError("...") will remain in the binding code.

In this bug, we fix (1).
Comment 1 Kentaro Hara 2012-04-23 15:47:19 PDT 
Created attachment 138443 [details]
Patch
Comment 2 Kentaro Hara 2012-04-24 10:05:26 PDT 
We need to fix JSC side too to align the behavior, and thus the fix would be controversial. Let me mark as WONTFIX for now.