Bug 84634 - [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
Summary: [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 14:33 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-08 17:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.23 KB, patch)
2012-04-23 14:34 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Convert another method in LTC (8.84 KB, patch)
2012-04-25 15:26 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch for landing (9.18 KB, patch)
2012-05-08 17:41 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-04-23 14:33:10 PDT 
[EFL] Pass a WTF::String directly from DRT to ewebkit when possible
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-04-23 14:34:48 PDT 
Created attachment 138427 [details]
Patch
Comment 2 Grzegorz Czajkowski 2012-04-23 23:31:21 PDT 
Makes sense, LGTM.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-04-25 15:26:01 PDT 
Created attachment 138883 [details]
Convert another method in LTC
Comment 4 WebKit Review Bot 2012-05-08 17:08:52 PDT 
Comment on attachment 138883 [details]
Convert another method in LTC

Rejecting attachment 138883 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
RenderTreeSupportEfl.h.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Hunk #1 succeeded at 184 (offset -5 lines).
Hunk #2 succeeded at 270 (offset 3 lines).
Hunk #3 succeeded at 515 (offset 6 lines).
Hunk #4 succeeded at 701 (offset 37 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12601016
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-08 17:41:20 PDT 
Created attachment 140830 [details]
Patch for landing
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-08 17:42:26 PDT 
Committed r116470: <http://trac.webkit.org/changeset/116470>