Bug 84613 – Insert source file and line number for v8 function calls into tracing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

Insert source file and line number for v8 function calls into tracing

[Adrienne Walker]

Created attachment 138381 [details]
Patch

[Adrienne Walker]

Do any of y'all know who the right person to review this would be?

[Kentaro Hara]

Comment on attachment 138381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138381&action=review

> Source/WebCore/ChangeLog:7
> +

Please explain the rational for the change.

> Source/WebCore/bindings/v8/V8Proxy.cpp:435
> +    Vector<UChar> combine;
> +    append(combine, resourceName);
> +    combine.append(':');
> +    appendNumber(combine, lineNumber);
> +
> +    String final;
> +    final = String::adopt(combine);
> +    return final;

Shall we use StringBuilder?

> Source/WebCore/platform/chromium/TraceEvent.h:677
> +    explicit TraceStringWithCopy(const unsigned char* str) : m_str(reinterpret_cast<const char*>(str)) { }

What is this change for?

[Adrienne Walker]

Created attachment 142369 [details]
Patch

[Adrienne Walker]

(In reply to comment #3)
> (From update of attachment 138381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138381&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please explain the rational for the change.

Done.

> > Source/WebCore/bindings/v8/V8Proxy.cpp:435
> > +    Vector<UChar> combine;
> > +    append(combine, resourceName);
> > +    combine.append(':');
> > +    appendNumber(combine, lineNumber);
> > +
> > +    String final;
> > +    final = String::adopt(combine);
> > +    return final;
> 
> Shall we use StringBuilder?

Done.

> > Source/WebCore/platform/chromium/TraceEvent.h:677
> > +    explicit TraceStringWithCopy(const unsigned char* str) : m_str(reinterpret_cast<const char*>(str)) { }
> 
> What is this change for?

It looks like this is no longer needed.  Removed.

[Kentaro Hara]

Comment on attachment 142369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142369&action=review

Looks OK

> Source/WebCore/bindings/v8/V8Proxy.cpp:412
> +    builder.append(String::String::number(lineNumber));

String::String::number() => String::number()

[Adrienne Walker]

Committed r117466: <http://trac.webkit.org/changeset/117466>