Bug 84611 - EWS bots have no timeout protection for the c++ unittests
Summary: EWS bots have no timeout protection for the c++ unittests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 10:34 PDT by Eric Seidel (no email)
Modified: 2014-10-10 14:48 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-04-23 10:34:00 PDT 
All Chromium EWS bots are hung running unit tests

I guess the c++ unittests have no hang protection.


[----------] 8 tests from TreeSynchronizerTest
[ RUN      ] TreeSynchronizerTest.syncNullTree
[       OK ] TreeSynchronizerTest.syncNullTree (0 ms)
[ RUN      ] TreeSynchronizerTest.syncSimpleTreeFromEmpty
[       OK ] TreeSynchronizerTest.syncSimpleTreeFromEmpty (0 ms)
[ RUN      ] TreeSynchronizerTest.syncSimpleTreeReusingLayers

(hang here forever)

Some patch 1.5 days ago hung all the bots.  Still figuring out which patch. :)
Comment 1 Eric Seidel (no email) 2012-04-23 10:35:44 PDT 
cr-linux #1 is hung processing bug 84524.
Comment 2 Eric Seidel (no email) 2012-04-23 10:42:03 PDT 
Same hang for cr-linux-3:

[----------] 8 tests from TreeSynchronizerTest
[ RUN      ] TreeSynchronizerTest.syncNullTree
[       OK ] TreeSynchronizerTest.syncNullTree (0 ms)
[ RUN      ] TreeSynchronizerTest.syncSimpleTreeFromEmpty
[       OK ] TreeSynchronizerTest.syncSimpleTreeFromEmpty (0 ms)
[ RUN      ] TreeSynchronizerTest.syncSimpleTreeReusingLayers

Was also hung on bug 84524
Comment 3 James Robinson 2012-04-23 10:47:57 PDT 
The googletest harness doesn't have appear to have a built-in test timeout mechanism: http://code.google.com/p/googletest/issues/detail?id=348, so this would probably have to be written in the python layer. We run the unit tests in a child process so that probably wouldn't be too hard.