Bug 84610 - SVG feConvolveMatrix does not implement kernelUnitLength
Summary: SVG feConvolveMatrix does not implement kernelUnitLength
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 10:28 PDT by Stephen Chenney
Modified: 2022-07-14 12:48 PDT (History)
8 users (show)

See Also:


Attachments
smiley.jpeg (6.25 KB, image/jpeg)
2022-07-14 12:46 PDT, Said Abou-Hallawa
no flags Details
test case (5.47 KB, text/html)
2022-07-14 12:48 PDT, Said Abou-Hallawa
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Chenney 2012-04-23 10:28:00 PDT
The code in FEConvolveMatrix::platformApply does not make any use of the kernelUnitLength property on the filter. Code search did turn up any usage anywhere. I conclude that we have not implemented it.
Comment 1 Dirk Schulze 2012-04-23 10:30:20 PDT
(In reply to comment #0)
> The code in FEConvolveMatrix::platformApply does not make any use of the kernelUnitLength property on the filter. Code search did turn up any usage anywhere. I conclude that we have not implemented it.

That is correct. I think the current spec is a bit vague on how it should work. At least it was not clear to me how we could implement at the time I worked on SVG filters.
Comment 3 Ryosuke Niwa 2022-07-14 11:57:36 PDT
Said? Is this now implemented?
Comment 4 Said Abou-Hallawa 2022-07-14 12:45:13 PDT
No it is not implemented. See FEConvolveMatrixSoftwareApplier::apply() and notice that m_effect.kernelUnitLength() is not used.
Comment 5 Said Abou-Hallawa 2022-07-14 12:46:19 PDT
Created attachment 460900 [details]
smiley.jpeg
Comment 6 Said Abou-Hallawa 2022-07-14 12:48:21 PDT
Created attachment 460901 [details]
test case

Two different filters are applied to the two images. FireFox is the only browser that renders the second image correctly.