Bug 84594 - [Qt] Incomplete interaction-engine reset
Summary: [Qt] Incomplete interaction-engine reset
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Depends on:
Reported: 2012-04-23 06:50 PDT by Allan Sandfeld Jensen
Modified: 2012-04-24 01:53 PDT (History)
3 users (show)

See Also:

Patch (1.56 KB, patch)
2012-04-23 06:52 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2012-04-23 07:43 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-04-23 06:50:32 PDT
The scaling stack is not reset in QtViewportInteractionEngine::reset(), this leads to odd zooming behaviour if first using the tap-to-zoom gesture and then resizing the viewport in the minibrowser.
Comment 1 Allan Sandfeld Jensen 2012-04-23 06:52:11 PDT
Created attachment 138339 [details]
Comment 2 Alexis Menard (darktears) 2012-04-23 06:58:46 PDT
Comment on attachment 138339 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=138339&action=review

Could you look if m_pinchStartScale needs also to be reset? I mean since you are fixing the reset method make sure all the content that needs to be cleared is actually reset.

> Source/WebKit2/ChangeLog:3
> +        [Qt] Scaling stack not reset on reset.

nitpick : Scaling stack not cleared on reset.
Comment 3 Allan Sandfeld Jensen 2012-04-23 07:43:11 PDT
Created attachment 138342 [details]
Comment 4 WebKit Review Bot 2012-04-24 01:53:03 PDT
Comment on attachment 138342 [details]

Clearing flags on attachment: 138342

Committed r115012: <http://trac.webkit.org/changeset/115012>
Comment 5 WebKit Review Bot 2012-04-24 01:53:23 PDT
All reviewed patches have been landed.  Closing bug.