Bug 84593 - [EFL][DRT] WebKitAnimation API compile-time disabled
Summary: [EFL][DRT] WebKitAnimation API compile-time disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 06:35 PDT by Dominik Röttsches (drott)
Modified: 2012-08-03 00:33 PDT (History)
12 users (show)

See Also:


Attachments
Patch (4.84 KB, patch)
2012-08-01 22:10 PDT, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-04-23 06:35:50 PDT
animations/animation-api-1.html fails since the API object is not present.
Comment 1 Dominik Röttsches (drott) 2012-04-23 07:45:05 PDT
webkitGetAnimations() is conditional on ENABLE_ANIMATION_API and currently disabled.
Comment 2 Joone Hur 2012-07-31 23:51:30 PDT
The test case was added by this commit: https://trac.webkit.org/changeset/80846
Comment 3 Joone Hur 2012-08-01 22:10:35 PDT
Created attachment 155973 [details]
Patch
Comment 4 Joone Hur 2012-08-01 22:17:35 PDT
Enabling ENABLE_ANIMATION_API flag makes animations/animation-api-1.html pass on WK1 and WK2 test.
Comment 5 Ryuan Choi 2012-08-01 22:23:26 PDT
LGTM.
Comment 6 Laszlo Gombos 2012-08-02 16:10:47 PDT
Comment on attachment 155973 [details]
Patch

r=me.

Is this the only test passing from the Skipped list by enabling this feature flag ?
Comment 7 Joone Hur 2012-08-02 23:55:15 PDT
(In reply to comment #6)
> (From update of attachment 155973 [details])
> r=me.
> 
> Is this the only test passing from the Skipped list by enabling this feature flag ?

Yes, this test case passes by just enabling ENABLE_ANIMATION_API flag.
Thanks for r+.
Comment 8 WebKit Review Bot 2012-08-03 00:33:26 PDT
Comment on attachment 155973 [details]
Patch

Clearing flags on attachment: 155973

Committed r124569: <http://trac.webkit.org/changeset/124569>
Comment 9 WebKit Review Bot 2012-08-03 00:33:34 PDT
All reviewed patches have been landed.  Closing bug.