RESOLVED FIXED Bug 84590
Web Inspector: improve the way heap snapshot diff is calculated 
https://bugs.webkit.org/show_bug.cgi?id=84590
Summary Web Inspector: improve the way heap snapshot diff is calculated
Yury Semikhatsky
Reported 2012-04-23 06:15:45 PDT
Now front-end will create nodes for each class and ask each of them to calculate diff for given class. After that classes with zero diff will be dropped. This creates unnecessary traffic between the DataGrid nodes and snapshot workers. Would be more efficient to first collect necessary data from the base snapshot and pass it once to the second snapshot so that it can perform all processing.
Attachments
Patch (24.62 KB, patch)
2012-04-23 06:25 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-04-23 06:25:16 PDT
Created attachment 138332 [details] Patch
Yury Semikhatsky
Comment 2 2012-04-23 06:43:50 PDT
(In reply to comment #1) > Created an attachment (id=138332) [details] > Patch The patch makes diff calculation about twice as fast.
Yury Semikhatsky
Comment 3 2012-04-23 06:49:22 PDT
Committed r114894: <http://trac.webkit.org/changeset/114894>
Alexei Filippov
Comment 4 2012-04-23 10:16:57 PDT
Why no push to addedIndexes at 1583?
Note You need to log in before you can comment on or make changes to this bug.