Bug 84583 - Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first.
Summary: Incremental rendering should be unsuppressed after the load event or a config...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-04-23 03:16 PDT by Andy Estes
Modified: 2012-04-24 00:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.34 KB, patch)
2012-04-23 03:33 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (13.33 KB, patch)
2012-04-23 12:31 PDT, Andy Estes 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-04-23 03:16:06 PDT 
Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first.
Comment 1 Andy Estes 2012-04-23 03:17:28 PDT 
<rdar://problem/11292192>
Comment 2 Andy Estes 2012-04-23 03:33:02 PDT 
Created attachment 138320 [details]
Patch
Comment 3 Andy Estes 2012-04-23 12:16:26 PDT 
Comment on attachment 138320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138320&action=review

> Source/WebCore/dom/Document.cpp:1203
> +#if USE(ACCELENRATED_COMPOSITING)

Oops.

> Source/WebKit/mac/WebView/WebView.mm:1519
> +    settings->setIncrementalRenderingSuppressionTimeoutInSeconds([preferences incrementalRenderingSuppressionTimeoutInSeconds]);

This has the effect of disabling incremental rendering suppression unless the preference is actually set. What I actually want in this case is the default timeout.
Comment 4 Andy Estes 2012-04-23 12:31:57 PDT 
Created attachment 138398 [details]
Patch
Comment 5 Andy Estes 2012-04-24 00:43:51 PDT 
Committed r115005: <http://trac.webkit.org/changeset/115005>