Bug 84552 - [Chromium] Remove Webkit/chromium/public/WebReferrerPolicy.h thunk.
: [Chromium] Remove Webkit/chromium/public/WebReferrerPolicy.h thunk.
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 85079
:
  Show dependency treegraph
 
Reported: 2012-04-22 14:57 PST by
Modified: 2012-04-30 15:41 PST (History)


Attachments
Patch (3.47 KB, patch)
2012-04-22 14:59 PST, Gavin Peters
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-22 14:57:24 PST
[Chromium] Remove Webkit/chromium/public/WebReferrerPolicy.h thunk.
------- Comment #1 From 2012-04-22 14:59:27 PST -------
Created an attachment (id=138276) [details]
Patch
------- Comment #2 From 2012-04-22 15:05:09 PST -------
See https://bugs.webkit.org/show_bug.cgi?id=82478 and https://github.com/gavinp/git.webkit.org/commit/497ceedf75c56614eb610bcbd5559e682e7c7382 for Adam Barth's review.

This can't land until after http://codereview.chromium.org/10139023/ , or else it will break the build...
------- Comment #3 From 2012-04-27 04:12:15 PST -------
(From update of attachment 138276 [details])
This is now reviewable, as its dependant change has landed in chromium.

jamesr, wdyt?
------- Comment #4 From 2012-04-27 04:12:42 PST -------
oops: forgot to add you earlier.  jamesr, wdyt?
------- Comment #5 From 2012-04-27 04:14:44 PST -------
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
------- Comment #6 From 2012-04-27 04:15:13 PST -------
(From update of attachment 138276 [details])
n/m James, this was already reviewed by abarth!
------- Comment #7 From 2012-04-27 07:32:24 PST -------
(From update of attachment 138276 [details])
I wish I could wait on chromium EWS, but instead I'll trust the CQ as the potential error is caught early.  Ugh, though.
------- Comment #8 From 2012-04-27 08:56:21 PST -------
(From update of attachment 138276 [details])
Clearing flags on attachment: 138276

Committed r115436: <http://trac.webkit.org/changeset/115436>
------- Comment #9 From 2012-04-27 08:56:26 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #10 From 2012-04-27 10:36:58 PST -------
Rolled out in http://trac.webkit.org/changeset/115448
------- Comment #11 From 2012-04-27 16:58:26 PST -------
(From update of attachment 138276 [details])
Attachment 138276 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12551380
------- Comment #12 From 2012-04-30 14:07:11 PST -------
(From update of attachment 138276 [details])
I'm feeling much luckier today.
------- Comment #13 From 2012-04-30 15:41:02 PST -------
(From update of attachment 138276 [details])
Clearing flags on attachment: 138276

Committed r115680: <http://trac.webkit.org/changeset/115680>
------- Comment #14 From 2012-04-30 15:41:10 PST -------
All reviewed patches have been landed.  Closing bug.