Bug 84541 – DisplayRefreshMonitorMac passes outputTime instead of now to ScriptedAnimationController

• Status: NEW
• Component: New Bugs

[Nat Duca]

DisplayRefreshMonitorMac passes outputTime instead of now to ScriptedAnimationController

[Nat Duca]

Created attachment 138264 [details]
Patch

[Nat Duca]

Perhaps I'm late to this party and posting a patch "after the debate."

I noticed in changing raf to use high res time that not all our platforms are agreeing on the semantic meaning of the animationStartTime argument on the requestAnimationFrame callback. Other platforms != mac pass the time when everyone begins animating. The mac platform is passing the output time.

This patch is mainly to figure out what opinions are.

Really, we need to pass both. But, until we get that done, what should we pass?

If it ends up being that we want mac to pass the output time as animationStartTime, I can kill this patch and/or update some of our variable bikesheds to make the meaning more precise.

[Eric Seidel (no email)]

Comment on attachment 138264 [details]
Patch

cc1plus: warnings being treated as errors
/Volumes/Data/WebKit/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp:87: warning: unused parameter 'nowSeconds'
/Volumes/Data/WebKit/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp:87: warning: unused parameter 'outputTimeSeconds'

[Eric Seidel (no email)]

I wonder if the mac-ews account does not have edit-bugs. It should have marked it cq-.

[Lucas Forschler]

I have confirmed that the ews bot has edit bugs permissions.  I don't think that is the issue.

[Simon Fraser (smfr)]

I think we fixed this.