Bug 84535 – Blackberry incorrectly only allows netscape plugins named jnext and flash

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Benjamin Meyer]

The original implement ion of FrameLoaderClientBlackBerry::createPlugin was a partial copy from another port.  In the Qt port there is some workarounds for flash which is why this exists there.  Sadly the bits that were copied made it so only flash worked, but as flash was the only plugin on the system this issue was not noticed until QNX tried to get jnext working.  Tracing it down to this bit of code rather then correcting it they hardcoded the jnext into the same block as flash was.

The blackberry port isn't specifically suppose to only allow jnext and flash, but was an accident due to the way this code was developed.

[Benjamin Meyer]

Created attachment 138245 [details]
patch

[WebKit Review Bot]

Attachment 138245 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Treat]

Comment on attachment 138245 [details]
patch

Put the bug number in the changelog and commit message.  Also, remove the typo in the changelog entry for 'implement ion'  that should be 'implementation'

[Benjamin Meyer]

Created attachment 138247 [details]
patch

[WebKit Review Bot]

Comment on attachment 138247 [details]
patch

Clearing flags on attachment: 138247

Committed r114849: <http://trac.webkit.org/changeset/114849>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.