Bug 84534 - [EFL] WebGL support ewk_view setting
Summary: [EFL] WebGL support ewk_view setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 83007
  Show dependency treegraph
 
Reported: 2012-04-21 09:47 PDT by Mikhail Pozdnyakov
Modified: 2012-05-22 11:11 PDT (History)
5 users (show)

See Also:


Attachments
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. (4.05 KB, patch)
2012-04-21 10:03 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. (4.05 KB, patch)
2012-04-26 00:19 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-04-21 09:47:29 PDT
ewk_view should expose webGLEnabled setting in order to provide EFL's LayoutTestController overridePreference implementation.
Comment 1 Mikhail Pozdnyakov 2012-04-21 10:03:36 PDT
Created attachment 138242 [details]
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-04-21 19:46:37 PDT
Comment on attachment 138242 [details]
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

Looks sane.
Comment 3 Gyuyoung Kim 2012-04-25 17:55:02 PDT
Comment on attachment 138242 [details]
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

View in context: https://bugs.webkit.org/attachment.cgi?id=138242&action=review

Almost looks good to me except for trivial my comment.

> Source/WebKit/efl/ChangeLog:6
> +        Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

Generally, patch description is located below "Reviewed by NOBODY (OOPS!)."
Comment 4 Mikhail Pozdnyakov 2012-04-26 00:19:25 PDT
Created attachment 138947 [details]
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

Changelog fixed.
Comment 5 Gyuyoung Kim 2012-04-26 01:39:53 PDT
Looks good to me now.
Comment 6 WebKit Review Bot 2012-04-26 06:33:20 PDT
Comment on attachment 138947 [details]
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

Clearing flags on attachment: 138947

Committed r115306: <http://trac.webkit.org/changeset/115306>
Comment 7 WebKit Review Bot 2012-04-26 06:33:24 PDT
All reviewed patches have been landed.  Closing bug.