RESOLVED FIXED84534
[EFL] WebGL support ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84534
Summary [EFL] WebGL support ewk_view setting
Mikhail Pozdnyakov
Reported 2012-04-21 09:47:29 PDT
ewk_view should expose webGLEnabled setting in order to provide EFL's LayoutTestController overridePreference implementation.
Attachments
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. (4.05 KB, patch)
2012-04-21 10:03 PDT, Mikhail Pozdnyakov
no flags
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. (4.05 KB, patch)
2012-04-26 00:19 PDT, Mikhail Pozdnyakov
no flags
Mikhail Pozdnyakov
Comment 1 2012-04-21 10:03:36 PDT
Created attachment 138242 [details] Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-04-21 19:46:37 PDT
Comment on attachment 138242 [details] Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. Looks sane.
Gyuyoung Kim
Comment 3 2012-04-25 17:55:02 PDT
Comment on attachment 138242 [details] Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. View in context: https://bugs.webkit.org/attachment.cgi?id=138242&action=review Almost looks good to me except for trivial my comment. > Source/WebKit/efl/ChangeLog:6 > + Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. Generally, patch description is located below "Reviewed by NOBODY (OOPS!)."
Mikhail Pozdnyakov
Comment 4 2012-04-26 00:19:25 PDT
Created attachment 138947 [details] Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. Changelog fixed.
Gyuyoung Kim
Comment 5 2012-04-26 01:39:53 PDT
Looks good to me now.
WebKit Review Bot
Comment 6 2012-04-26 06:33:20 PDT
Comment on attachment 138947 [details] Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support. Clearing flags on attachment: 138947 Committed r115306: <http://trac.webkit.org/changeset/115306>
WebKit Review Bot
Comment 7 2012-04-26 06:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.