Bug 84525 - Improve performance of removing user and password from URLs
Summary: Improve performance of removing user and password from URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-21 02:13 PDT by Darin Adler
Modified: 2013-06-11 16:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2012-04-21 02:15 PDT, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
Improve performance of removing user and password from URLs By making the new remove function. (4.15 KB, patch)
2013-05-28 23:08 PDT, Meeyoung Kim 		meeyoung.kim: review+
meeyoung.kim: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2012-04-21 02:13:26 PDT 
Improve performance of removing user and password from URLs
Comment 1 Darin Adler 2012-04-21 02:15:55 PDT 
Created attachment 138229 [details]
Patch
Comment 2 Darin Adler 2012-04-21 09:43:32 PDT 
Committed r114843: <http://trac.webkit.org/changeset/114843>
Comment 3 Meeyoung Kim 2013-05-28 22:54:34 PDT 
"Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials().

In thease case, the aim of setUser() and setPass() is that removing the user and passward from m_string.

But the user is not removed from m_string in this commited r114843. Because user is empty.
Comment 4 Meeyoung Kim 2013-05-28 23:08:56 PDT 
Created attachment 203122 [details]
Improve performance of removing user and password from URLs By making the new remove function.

"Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials().

In thease case, the aim of setUser() and setPass() is that removing the user and passward from m_string.

But the user is not removed from m_string in this commited r114843. Because user is empty.

So, Improve performance of removing user and password from URLs By making the new remove function.
Comment 5 Meeyoung Kim 2013-05-28 23:26:56 PDT 
created Bug 116909.
Comment 6 Meeyoung Kim 2013-06-11 16:18:55 PDT 
My comment is wrong. It is not a bug.
(In reply to comment #3)
> "Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials().
> 
> In thease case, the aim of setUser() and setPass() is that removing the user and passward from m_string.
> 
> But the user is not removed from m_string in this commited r114843. Because user is empty.