RESOLVED FIXED 84525
Improve performance of removing user and password from URLs 
https://bugs.webkit.org/show_bug.cgi?id=84525
Summary Improve performance of removing user and password from URLs
Darin Adler
Reported 2012-04-21 02:13:26 PDT
Improve performance of removing user and password from URLs
Attachments
Patch (3.64 KB, patch)
2012-04-21 02:15 PDT, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
Improve performance of removing user and password from URLs By making the new remove function. (4.15 KB, patch)
2013-05-28 23:08 PDT, Meeyoung Kim 		meeyoung.kim: review+
meeyoung.kim: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2012-04-21 02:15:55 PDT
Created attachment 138229 [details] Patch
Darin Adler
Comment 2 2012-04-21 09:43:32 PDT
Committed r114843: <http://trac.webkit.org/changeset/114843>
Meeyoung Kim
Comment 3 2013-05-28 22:54:34 PDT
"Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials(). In thease case, the aim of setUser() and setPass() is that removing the user and passward from m_string. But the user is not removed from m_string in this commited r114843. Because user is empty.
Meeyoung Kim
Comment 4 2013-05-28 23:08:56 PDT
Created attachment 203122 [details] Improve performance of removing user and password from URLs By making the new remove function. "Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials(). In thease case, the aim of setUser() and setPass() is that removing the user and passward from m_string. But the user is not removed from m_string in this commited r114843. Because user is empty. So, Improve performance of removing user and password from URLs By making the new remove function.
Meeyoung Kim
Comment 5 2013-05-28 23:26:56 PDT
created Bug 116909.
Meeyoung Kim
Comment 6 2013-06-11 16:18:55 PDT
My comment is wrong. It is not a bug. (In reply to comment #3) > "Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials(). > > In thease case, the aim of setUser() and setPass() is that removing the user and passward from m_string. > > But the user is not removed from m_string in this commited r114843. Because user is empty.
Note You need to log in before you can comment on or make changes to this bug.