Bug 84512 - Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
Summary: Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 16:46 PDT by Brady Eidson
Modified: 2012-04-20 17:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 - Do the rename and get rid of the unnecessary argument (11.89 KB, patch)
2012-04-20 16:51 PDT, Brady Eidson 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-04-20 16:46:42 PDT 
Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading

All of the ActiveDOMObject ReasonForSuspensions are great, but only a *single* subclass does anything special for a particular Reason.  And it's not WillShowDialog.

WillShowDialog is used whenever we defer page loading and has no special meaning beyond that.

We should rename it, then use it by default in all page load deferral cases without having to pass the argument around.

Noticed while exploring https://bugs.webkit.org/show_bug.cgi?id=84488
Comment 1 Brady Eidson 2012-04-20 16:51:48 PDT 
Created attachment 138199 [details]
Patch v1 - Do the rename and get rid of the unnecessary argument
Comment 2 Brady Eidson 2012-04-20 17:07:33 PDT 
http://trac.webkit.org/changeset/114802