Bug 84501 – REGRESSION (r94497): Pressing Command+A when inline (Marked Text) is not empty will clean whole content

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Alexey Proskuryakov]

Steps to reproduce:
1. Type anything in any editable content (contenteditable, textarea, Mail.app etc.)
2. Type anything else with an input method using inline input (such as Kotoeri).
3. Hit Cmd+A

Results: entire editable content disappears.
Expected results: input area is confirmed, all text is selected.

<rdar://problem/11242705>

[Alexey Proskuryakov]

Ryosuke, would you be willing to look into this?

[Ryosuke Niwa]

Interesting this bug doesn't reproduce on Chrome because we ignore Cmd+A.

[Ryosuke Niwa]

We're hitting:

    // If text is empty, then delete the old composition here.  If text is non-empty, InsertTextCommand::input
    // will delete the old composition with an optimized replace operation.
    if (text.isEmpty())
        TypingCommand::deleteSelection(m_frame->document(), 0);

[Ryosuke Niwa]

Created attachment 139135 [details]
Fixes the bug

[Alexey Proskuryakov]

Comment on attachment 139135 [details]
Fixes the bug

Thank you!

I suggest putting this test in editing/input. Ports that don't implement textInputController often skip the whole directory, so it's less book-keeping for everyone.

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 139135 [details])
> Thank you!
> 
> I suggest putting this test in editing/input. Ports that don't implement textInputController often skip the whole directory, so it's less book-keeping for everyone.

Okay, will do.

[Ryosuke Niwa]

Committed r115409: <http://trac.webkit.org/changeset/115409>