Bug 84499 – [chromium] Disable battery-status API support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Sadrul Habib Chowdhury]

Disable battery-status API support until it is properly fixed up (see: https://bugs.webkit.org/show_bug.cgi?id=83284#c50)

[Sadrul Habib Chowdhury]

Created attachment 138174 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138174 [details]
Patch

Attachment 138174 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12465414

New failing tests:
batterystatus/event-after-navigation.html
batterystatus/basic-operation.html
fast/dom/navigator-detached-no-crash.html
batterystatus/basic-all-types-of-events.html
batterystatus/window-property.html
batterystatus/multiple-frames.html
batterystatus/add-listener-from-callback.html
batterystatus/updates.html

[WebKit Review Bot]

Created attachment 138211 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[WebKit Review Bot]

Comment on attachment 138174 [details]
Patch

Attachment 138174 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12476352

New failing tests:
batterystatus/event-after-navigation.html
batterystatus/basic-operation.html
fast/dom/navigator-detached-no-crash.html
batterystatus/basic-all-types-of-events.html
batterystatus/window-property.html
batterystatus/multiple-frames.html
batterystatus/add-listener-from-callback.html
batterystatus/updates.html

[WebKit Review Bot]

Created attachment 138215 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Sadrul Habib Chowdhury]

Created attachment 138260 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138260 [details]
Patch

Attachment 138260 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12480496

New failing tests:
fast/dom/navigator-detached-no-crash.html

[WebKit Review Bot]

Created attachment 138262 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Sadrul Habib Chowdhury]

Created attachment 138356 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138356 [details]
Patch

Clearing flags on attachment: 138356

Committed r115682: <http://trac.webkit.org/changeset/115682>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Zhenyao Mo]

By the way, on a bunch of Windows bots, we still get 

navigator.webkitBattery is OK

I didn't revert your patch because this failure seems like a no-big-deal thing, but why we still get that property on Windows?  How do we fix that?

[Zhenyao Mo]

never mind.  it's turning green after a few runs.