Bug 84499 - [chromium] Disable battery-status API support
Summary: [chromium] Disable battery-status API support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sadrul Habib Chowdhury
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 15:03 PDT by Sadrul Habib Chowdhury
Modified: 2012-04-30 18:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.30 KB, patch)
2012-04-20 15:04 PDT, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-04 (6.13 MB, application/zip)
2012-04-20 18:14 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from ec2-cr-linux-02 (5.71 MB, application/zip)
2012-04-20 19:10 PDT, WebKit Review Bot
no flags Details
Patch (2.69 KB, patch)
2012-04-21 17:18 PDT, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (6.27 MB, application/zip)
2012-04-21 18:34 PDT, WebKit Review Bot
no flags Details
Patch (3.87 KB, patch)
2012-04-23 08:49 PDT, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sadrul Habib Chowdhury 2012-04-20 15:03:56 PDT
Disable battery-status API support until it is properly fixed up (see: https://bugs.webkit.org/show_bug.cgi?id=83284#c50)
Comment 1 Sadrul Habib Chowdhury 2012-04-20 15:04:38 PDT
Created attachment 138174 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-20 18:14:26 PDT
Comment on attachment 138174 [details]
Patch

Attachment 138174 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12465414

New failing tests:
batterystatus/event-after-navigation.html
batterystatus/basic-operation.html
fast/dom/navigator-detached-no-crash.html
batterystatus/basic-all-types-of-events.html
batterystatus/window-property.html
batterystatus/multiple-frames.html
batterystatus/add-listener-from-callback.html
batterystatus/updates.html
Comment 3 WebKit Review Bot 2012-04-20 18:14:31 PDT
Created attachment 138211 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 WebKit Review Bot 2012-04-20 19:10:25 PDT
Comment on attachment 138174 [details]
Patch

Attachment 138174 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12476352

New failing tests:
batterystatus/event-after-navigation.html
batterystatus/basic-operation.html
fast/dom/navigator-detached-no-crash.html
batterystatus/basic-all-types-of-events.html
batterystatus/window-property.html
batterystatus/multiple-frames.html
batterystatus/add-listener-from-callback.html
batterystatus/updates.html
Comment 5 WebKit Review Bot 2012-04-20 19:10:31 PDT
Created attachment 138215 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Sadrul Habib Chowdhury 2012-04-21 17:18:23 PDT
Created attachment 138260 [details]
Patch
Comment 7 WebKit Review Bot 2012-04-21 18:34:23 PDT
Comment on attachment 138260 [details]
Patch

Attachment 138260 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12480496

New failing tests:
fast/dom/navigator-detached-no-crash.html
Comment 8 WebKit Review Bot 2012-04-21 18:34:29 PDT
Created attachment 138262 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 9 Sadrul Habib Chowdhury 2012-04-23 08:49:49 PDT
Created attachment 138356 [details]
Patch
Comment 10 WebKit Review Bot 2012-04-30 15:43:31 PDT
Comment on attachment 138356 [details]
Patch

Clearing flags on attachment: 138356

Committed r115682: <http://trac.webkit.org/changeset/115682>
Comment 11 WebKit Review Bot 2012-04-30 15:43:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Zhenyao Mo 2012-04-30 17:50:19 PDT
By the way, on a bunch of Windows bots, we still get 

navigator.webkitBattery is OK

I didn't revert your patch because this failure seems like a no-big-deal thing, but why we still get that property on Windows?  How do we fix that?
Comment 13 Zhenyao Mo 2012-04-30 18:49:52 PDT
never mind.  it's turning green after a few runs.