Bug 84496 - Clean up subpixel unit handling in hit testing code
Summary: Clean up subpixel unit handling in hit testing code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2012-04-20 14:40 PDT by Emil A Eklund
Modified: 2012-04-23 12:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.72 KB, patch)
2012-04-20 14:51 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch (4.82 KB, patch)
2012-04-23 10:26 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-04-20 14:40:38 PDT
We currently use IntRect where we should use LayoutRect and the other way around in a couple of places.
Comment 1 Emil A Eklund 2012-04-20 14:51:57 PDT
Created attachment 138170 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-20 15:49:08 PDT
Comment on attachment 138170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138170&action=review

> Source/WebCore/ChangeLog:9
> +        Fix use of IntRect and LayoutRect in hit testing code in preparation for
> +        subpixel layout.

Why?
Comment 3 Emil A Eklund 2012-04-20 16:57:53 PDT
(In reply to comment #2)
> Why?

I really should expand on that, thanks for pointing it out.
Comment 4 Emil A Eklund 2012-04-23 10:26:07 PDT
Created attachment 138377 [details]
Patch
Comment 5 Eric Seidel (no email) 2012-04-23 11:03:53 PDT
Comment on attachment 138377 [details]
Patch

I guess hit testing results are currently IntRects, so this isn't really a change.  I'm just slightly surprised we wouldnt' want them to be LayoutRects.
Comment 6 Emil A Eklund 2012-04-23 11:07:02 PDT
(In reply to comment #5)
> (From update of attachment 138377 [details])
> I guess hit testing results are currently IntRects, so this isn't really a change.  I'm just slightly surprised we wouldnt' want them to be LayoutRects.

Eventually we do want to move hit testing to LayoutUnits/Rects. I would prefer changing one system at a time though.
Comment 7 Emil A Eklund 2012-04-23 12:02:15 PDT
Committed r114926: <http://trac.webkit.org/changeset/114926>