We currently use IntRect where we should use LayoutRect and the other way around in a couple of places.
Created attachment 138170 [details] Patch
Comment on attachment 138170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138170&action=review > Source/WebCore/ChangeLog:9 > + Fix use of IntRect and LayoutRect in hit testing code in preparation for > + subpixel layout. Why?
(In reply to comment #2) > Why? I really should expand on that, thanks for pointing it out.
Created attachment 138377 [details] Patch
Comment on attachment 138377 [details] Patch I guess hit testing results are currently IntRects, so this isn't really a change. I'm just slightly surprised we wouldnt' want them to be LayoutRects.
(In reply to comment #5) > (From update of attachment 138377 [details]) > I guess hit testing results are currently IntRects, so this isn't really a change. I'm just slightly surprised we wouldnt' want them to be LayoutRects. Eventually we do want to move hit testing to LayoutUnits/Rects. I would prefer changing one system at a time though.
Committed r114926: <http://trac.webkit.org/changeset/114926>