Bug 84472 - Fix use of LayoutUnits in DOMNodeHighlighter
Summary: Fix use of LayoutUnits in DOMNodeHighlighter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-20 11:24 PDT by Emil A Eklund
Modified: 2012-04-20 13:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2012-04-20 11:34 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-04-20 11:24:36 PDT 
Bug 84181 added a bunch of new logic to DOMNodeHighlighter that doesn't use the right unit types.
Comment 1 Emil A Eklund 2012-04-20 11:34:25 PDT 
Created attachment 138127 [details]
Patch
Comment 2 Xianzhu Wang 2012-04-20 11:53:18 PDT 
Thanks Emil. Sorry I thought the methods accept LayoutUnits without checking. Will they be changed to LayoutUnits in the future?
Comment 3 Emil A Eklund 2012-04-20 11:54:46 PDT 
(In reply to comment #2)
> Thanks Emil. Sorry I thought the methods accept LayoutUnits without checking. Will they be changed to LayoutUnits in the future?

No worries. They might be, in the medium term they'll stay int based to line up with device pixels.

Thanks for asking.
Comment 4 WebKit Review Bot 2012-04-20 13:22:24 PDT 
Comment on attachment 138127 [details]
Patch

Clearing flags on attachment: 138127

Committed r114775: <http://trac.webkit.org/changeset/114775>
Comment 5 WebKit Review Bot 2012-04-20 13:22:41 PDT 
All reviewed patches have been landed.  Closing bug.