Bug 84471 - [BlackBerry] Expose WebViewportArguments to WebPageClient
Summary: [BlackBerry] Expose WebViewportArguments to WebPageClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 11:15 PDT by Mike Lattanzio
Modified: 2012-04-20 14:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.85 KB, patch)
2012-04-20 11:35 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff
Patch (14.41 KB, patch)
2012-04-20 11:37 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff
Patch (15.13 KB, patch)
2012-04-20 12:22 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff
Patch (15.31 KB, patch)
2012-04-20 12:56 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lattanzio 2012-04-20 11:15:34 PDT
Give our client implementation the ability to provide some fallback ViewportArguments. Now clients can essentially set a meta viewport to increase mobile readability without touching the HTML content they request to be loaded.
Comment 1 Mike Lattanzio 2012-04-20 11:35:06 PDT
Created attachment 138129 [details]
Patch
Comment 2 Mike Lattanzio 2012-04-20 11:37:33 PDT
Created attachment 138130 [details]
Patch
Comment 3 Mike Lattanzio 2012-04-20 12:22:58 PDT
Created attachment 138144 [details]
Patch
Comment 4 Konrad Piascik 2012-04-20 12:36:12 PDT
you still didn't explain in your patch why you need  currentViewportArguments and are not overriding m_viewportArguments, I think this is the important thing to note....also do you have any tests?
Comment 5 Mike Lattanzio 2012-04-20 12:56:43 PDT
Created attachment 138148 [details]
Patch
Comment 6 Mike Lattanzio 2012-04-20 13:00:12 PDT
(In reply to comment #4)
> you still didn't explain in your patch why you need  currentViewportArguments and are not overriding m_viewportArguments, I think this is the important thing to note....also do you have any tests?

The new patch has more thorough comments. API tests for the WebViewportArguments are in launcher. This patch doesn't affect anything by default so no new tests for webkit.
Comment 7 Konrad Piascik 2012-04-20 13:01:24 PDT
(In reply to comment #6)
> (In reply to comment #4)
> > you still didn't explain in your patch why you need  currentViewportArguments and are not overriding m_viewportArguments, I think this is the important thing to note....also do you have any tests?
> 
> The new patch has more thorough comments. API tests for the WebViewportArguments are in launcher. This patch doesn't affect anything by default so no new tests for webkit.

Looks good to me.
Comment 8 Antonio Gomes 2012-04-20 13:20:01 PDT
Comment on attachment 138148 [details]
Patch

still think d should not be a pointer, but ok.
Comment 9 WebKit Review Bot 2012-04-20 14:20:08 PDT
Comment on attachment 138148 [details]
Patch

Clearing flags on attachment: 138148

Committed r114779: <http://trac.webkit.org/changeset/114779>
Comment 10 WebKit Review Bot 2012-04-20 14:20:20 PDT
All reviewed patches have been landed.  Closing bug.