This change introduces abstract OpenResourceDialog and re-uses it in OpenScriptDialog and OpenStylesheetDialog.
Created attachment 138118 [details] Patch
Comment on attachment 138118 [details] Patch Attachment 138118 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12469270 New failing tests: http/tests/inspector/compiler-script-mapping.html
Created attachment 138128 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 138118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138118&action=review > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:657 > + // Overriden; Overriden -> Overriden in descendants. > Source/WebCore/inspector/front-end/ResourceUtils.js:63 > + if (this.url.indexOf("data:") == 0) { There was a discussion about using indexOf vs RegExp vs substring for prefix checks. On long strings RegExp is preferable and given that data: URL may be quite long, I'd suggest you use a regular expression or substring here.
Committed r114878: <http://trac.webkit.org/changeset/114878>