Bug 84466 - Web Inspector: implement "open stylesheet" dialog.
Summary: Web Inspector: implement "open stylesheet" dialog.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 10:33 PDT by Pavel Feldman
Modified: 2012-04-23 01:05 PDT (History)
12 users (show)

See Also:


Attachments
Patch (14.75 KB, patch)
2012-04-20 10:41 PDT, Pavel Feldman
yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (5.83 MB, application/zip)
2012-04-20 11:34 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-20 10:33:37 PDT
This change introduces abstract OpenResourceDialog and re-uses it in OpenScriptDialog and OpenStylesheetDialog.
Comment 1 Pavel Feldman 2012-04-20 10:41:03 PDT
Created attachment 138118 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-20 11:34:25 PDT
Comment on attachment 138118 [details]
Patch

Attachment 138118 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12469270

New failing tests:
http/tests/inspector/compiler-script-mapping.html
Comment 3 WebKit Review Bot 2012-04-20 11:34:37 PDT
Created attachment 138128 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Yury Semikhatsky 2012-04-22 22:29:25 PDT
Comment on attachment 138118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138118&action=review

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:657
> +        // Overriden;

Overriden ->  Overriden in descendants.

> Source/WebCore/inspector/front-end/ResourceUtils.js:63
> +        if (this.url.indexOf("data:") == 0) {

There was a discussion about using indexOf vs RegExp vs substring for prefix checks. On long strings RegExp is preferable and given that data: URL may be quite long, I'd suggest you use a regular expression or substring here.
Comment 5 Pavel Feldman 2012-04-23 01:05:57 PDT
Committed r114878: <http://trac.webkit.org/changeset/114878>