Bug 84461 – [EFL][DRT] SVG Batik test fails to display Chinese characters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Dominik Röttsches (drott)]

LayoutTests/svg/batik/text/verticalText.svg looks okay overall, only it doesn't show Chinese characters - font missing?

[Chris Dumez]

This is not in this test only. All the tests that require CJK fonts are failing.
The reason is that there are not CJK fonts in webkitgtkfonts package.

Adding a font like /usr/share/fonts/wqy-zenhei/wqy-zenhei.ttc (for chinese) fixes this test. It is under GNU GPL v2 (http://en.wikipedia.org/wiki/WenQuanYi).

[Chris Dumez]

This is not specific to EFL port by the way, the GTK port has exactly the same issue for this test since it is using the same font.

mrobinson: Is it possible to add fonts (like wqy-zenhei.ttc) to webkitgtkfonts if we notice some test cases require them?

[Chris Dumez]

Created attachment 140932 [details]
Patch

Add WenQuanYi fonts to jhbuild.modules and load them in DRT. Rebaseline EFL expectations for svg/batik/text/verticalText.svg now that Chinese characters are properly displayed.

[Chris Dumez]

Created attachment 140935 [details]
Patch

Regenerate diff with --binary so that PNG result is included.

[Chris Dumez]

Created attachment 140937 [details]
Patch

Fix printed message in case one of the font folders cannot be loaded (Thanks Dominik).

[Martin Robinson]

It's probably better to add this font directly to webkitgtk-test-fonts, indeed.

[Chris Dumez]

Comment on attachment 140937 [details]
Patch

Ok, clearing the flags then.

[Chris Dumez]

I made the following pull request to webkitgtk-fonts:
https://github.com/mrobinson/webkitgtk-test-fonts/pull/3

[Chris Dumez]

Made the following pull request to webkitgtk-fonts instead:
https://github.com/mrobinson/webkitgtk-test-fonts/pull/4

Now using the same fonts as chromium-linux.

[Martin Robinson]

(In reply to comment #9)
> Made the following pull request to webkitgtk-fonts instead:
> https://github.com/mrobinson/webkitgtk-test-fonts/pull/4
> 
> Now using the same fonts as chromium-linux.

Merged and uploaded a new version of the package: https://github.com/downloads/mrobinson/webkitgtk-test-fonts/webkitgtk-test-fonts-0.0.3.tar.gz

[Chris Dumez]

Created attachment 141356 [details]
Patch

Update to webkitgtk-fonts v0.0.3 and rebaseline svg/batik/text/verticalText.svg now that EFL's DumpRenderTree is able to display Chinese characters.

[Chris Dumez]

Addressing this issue on GTK port at Bug 86198.

[Raphael Kubo da Costa (:rakuco)]

Looks fine, thanks for working on this.

[WebKit Review Bot]

Comment on attachment 141356 [details]
Patch

Clearing flags on attachment: 141356

Committed r116776: <http://trac.webkit.org/changeset/116776>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.