Bug 84455 – [chromium] Don't crash when scrolling empty layer tree

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sami Kyostila]

[chromium] Don't crash when scrolling empty layer tree

[Sami Kyostila]

Created attachment 138096 [details]
Patch

[Dana Jansens]

Comment on attachment 138096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245
> +    if (!m_rootLayerImpl)
> +        return false;
> +

false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw.

[Sami Kyostila]

(In reply to comment #2)
> (From update of attachment 138096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245
> > +    if (!m_rootLayerImpl)
> > +        return false;
> > +
> 
> false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw.

Ah, I missed that. New patch coming up.

[Sami Kyostila]

Created attachment 138100 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138100 [details]
Patch

Clearing flags on attachment: 138100

Committed r114761: <http://trac.webkit.org/changeset/114761>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.