Bug 84455 - [chromium] Don't crash when scrolling empty layer tree
Summary: [chromium] Don't crash when scrolling empty layer tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyostila
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 08:20 PDT by Sami Kyostila
Modified: 2012-04-20 10:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.09 KB, patch)
2012-04-20 08:22 PDT, Sami Kyostila
no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2012-04-20 08:53 PDT, Sami Kyostila
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyostila 2012-04-20 08:20:06 PDT
[chromium] Don't crash when scrolling empty layer tree
Comment 1 Sami Kyostila 2012-04-20 08:22:36 PDT
Created attachment 138096 [details]
Patch
Comment 2 Dana Jansens 2012-04-20 08:40:43 PDT
Comment on attachment 138096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245
> +    if (!m_rootLayerImpl)
> +        return false;
> +

false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw.
Comment 3 Sami Kyostila 2012-04-20 08:47:46 PDT
(In reply to comment #2)
> (From update of attachment 138096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245
> > +    if (!m_rootLayerImpl)
> > +        return false;
> > +
> 
> false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw.

Ah, I missed that. New patch coming up.
Comment 4 Sami Kyostila 2012-04-20 08:53:35 PDT
Created attachment 138100 [details]
Patch
Comment 5 WebKit Review Bot 2012-04-20 10:53:27 PDT
Comment on attachment 138100 [details]
Patch

Clearing flags on attachment: 138100

Committed r114761: <http://trac.webkit.org/changeset/114761>
Comment 6 WebKit Review Bot 2012-04-20 10:53:37 PDT
All reviewed patches have been landed.  Closing bug.