Bug 84451 - [EFL] Hyperlink auditing ewk_view setting
Summary: [EFL] Hyperlink auditing ewk_view setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 83007
  Show dependency treegraph
 
Reported: 2012-04-20 07:52 PDT by Mikhail Pozdnyakov
Modified: 2012-05-22 11:11 PDT (History)
4 users (show)

See Also:


Attachments
Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing (5.45 KB, patch)
2012-04-21 09:09 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing (5.45 KB, patch)
2012-04-25 13:02 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-04-20 07:52:07 PDT
ewk_view should expose hyperlinkAuditingEnabled setting in order to provide EFL's LayoutTestController overridePreference implementation.
Comment 1 Mikhail Pozdnyakov 2012-04-21 09:09:46 PDT
Created attachment 138236 [details]
Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-04-21 19:57:36 PDT
Comment on attachment 138236 [details]
Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing

View in context: https://bugs.webkit.org/attachment.cgi?id=138236&action=review

Looks fine.

> Source/WebKit/efl/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

Minor nit: the "Reviewed by" line usually goes right after the bug link.
Comment 3 Mikhail Pozdnyakov 2012-04-25 13:02:33 PDT
Created attachment 138862 [details]
Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing

Fixed changelog.
Comment 4 Antonio Gomes 2012-05-02 07:32:48 PDT
Comment on attachment 138862 [details]
Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing

Is this only for LayoutTestController purposes? Should not it be better to use DumpRenderTreeSupportEFL instead?
Comment 5 Mikhail Pozdnyakov 2012-05-02 07:36:54 PDT
(In reply to comment #4)
> (From update of attachment 138862 [details])
> Is this only for LayoutTestController purposes? Should not it be better to use DumpRenderTreeSupportEFL instead?

Think having of such api is also important.
From the standard
http://www.whatwg.org/specs/web-apps/current-work/#hyperlink-auditing:

Based on the user's preferences, UAs may either ignore the ping attribute altogether, or selectively ignore URLs in the list (e.g. ignoring any third-party URLs).
Comment 6 Antonio Gomes 2012-05-02 07:39:05 PDT
Comment on attachment 138862 [details]
Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing

ok
Comment 7 WebKit Review Bot 2012-05-02 08:16:28 PDT
Comment on attachment 138862 [details]
Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing

Clearing flags on attachment: 138862

Committed r115834: <http://trac.webkit.org/changeset/115834>
Comment 8 WebKit Review Bot 2012-05-02 08:16:33 PDT
All reviewed patches have been landed.  Closing bug.