Bug 84447 - Web Inspector: follow up to r114729: more @return annotations added.
Summary: Web Inspector: follow up to r114729: more @return annotations added.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 06:52 PDT by Pavel Feldman
Modified: 2012-04-20 09:28 PDT (History)
10 users (show)

See Also:


Attachments
Patch (7.28 KB, patch)
2012-04-20 06:54 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-20 06:52:14 PDT
Patch to follow.
Comment 1 Pavel Feldman 2012-04-20 06:54:20 PDT
Created attachment 138087 [details]
Patch
Comment 2 Yury Semikhatsky 2012-04-20 09:17:44 PDT
Comment on attachment 138087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138087&action=review

> Source/WebCore/inspector/front-end/Resource.js:54
> +    /** @type {?string} */ this._content;

Type annotation should go above the field and the field should be initialized here.

> Source/WebCore/inspector/front-end/ResourceUtils.js:113
> +    var parsedURL = new WebInspector.ParsedURL(this.toString());

Why do you need to call toString()? Would @this {string} annotation help?
Comment 3 Pavel Feldman 2012-04-20 09:28:23 PDT
Committed r114754: <http://trac.webkit.org/changeset/114754>