WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84447
Web Inspector: follow up to
r114729
: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447
Summary
Web Inspector: follow up to r114729: more @return annotations added.
Pavel Feldman
Reported
2012-04-20 06:52:14 PDT
Patch to follow.
Attachments
Patch
(7.28 KB, patch)
2012-04-20 06:54 PDT
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-04-20 06:54:20 PDT
Created
attachment 138087
[details]
Patch
Yury Semikhatsky
Comment 2
2012-04-20 09:17:44 PDT
Comment on
attachment 138087
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=138087&action=review
> Source/WebCore/inspector/front-end/Resource.js:54 > + /** @type {?string} */ this._content;
Type annotation should go above the field and the field should be initialized here.
> Source/WebCore/inspector/front-end/ResourceUtils.js:113 > + var parsedURL = new WebInspector.ParsedURL(this.toString());
Why do you need to call toString()? Would @this {string} annotation help?
Pavel Feldman
Comment 3
2012-04-20 09:28:23 PDT
Committed
r114754
: <
http://trac.webkit.org/changeset/114754
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug