Bug 84433 - master.cfg cleanup, remove dead codes
Summary: master.cfg cleanup, remove dead codes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Reported: 2012-04-20 04:48 PDT by Csaba Osztrogonác
Modified: 2012-04-23 09:44 PDT (History)
6 users (show)

See Also:

Patch (6.60 KB, patch)
2012-04-20 04:50 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Csaba Osztrogonác 2012-04-20 04:50:29 PDT
Created attachment 138068 [details]
Comment 2 Eric Seidel (no email) 2012-04-20 12:36:26 PDT
Comment on attachment 138068 [details]

Was this for --no-svg builds?
Comment 3 Csaba Osztrogonác 2012-04-21 00:03:55 PDT
(In reply to comment #2)
> (From update of attachment 138068 [details])
> Was this for --no-svg builds?

No, it was for --css-regions and --css-exclusions build, and "upload" 
option was to a build only bot upload binaries if there isn't tester bot.
Comment 4 Csaba Osztrogonác 2012-04-23 01:51:30 PDT
Comment on attachment 138068 [details]

Clearing flags on attachment: 138068

Committed r114881: <http://trac.webkit.org/changeset/114881>
Comment 5 Csaba Osztrogonác 2012-04-23 01:51:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2012-04-23 03:52:39 PDT
Reopen, because it broke the upload buildstep:
(view as text)

Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
    result = f(*args, **kw)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 518, in startStep
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 298, in addCallback
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 287, in addCallbacks
--- <exception caught here> ---
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 545, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 560, in _startStep_2
    setattr(self, renderable, self.build.render(getattr(self, renderable)))
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 177, in render
    return props.render(value)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 137, in render
    return renderable.getRenderingFor(self)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 287, in getRenderingFor
    s = self.fmtstring % pmap
exceptions.TypeError: not enough arguments for format string

I rolled it out not to cause problem - http://trac.webkit.org/changeset/114886
Comment 7 Csaba Osztrogonác 2012-04-23 04:01:20 PDT
Mea Culpa, it was a typo. :( Fix is coming soon.
Comment 8 Csaba Osztrogonác 2012-04-23 04:48:25 PDT
Comment on attachment 138068 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=138068&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:210
> +    masterdest = WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%/%(got_revision)s.zip")

typo fix: %(configuration)s%/%(got_revision)s.zip --> %(configuration)s/%(got_revision)s.zip
I'm going to land the fixed patch later in an IDLE time of buildmaster not to break bots.
Comment 9 Csaba Osztrogonác 2012-04-23 08:42:20 PDT
Fixed patch landed in http://trac.webkit.org/changeset/114903
Comment 10 Eric Seidel (no email) 2012-04-23 09:44:32 PDT
When we re-land thsi, we should add a unittest to validate we don't break Upload again. :)