The temporary CSSRegions buildbot was removed by http://trac.webkit.org/changeset/92792/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json "upload" and "features" options introduced because of this bot: - http://trac.webkit.org/changeset/91782/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg - http://trac.webkit.org/changeset/92191/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Now they are dead code and should be removed.
Created attachment 138068 [details] Patch
Comment on attachment 138068 [details] Patch Was this for --no-svg builds?
(In reply to comment #2) > (From update of attachment 138068 [details]) > Was this for --no-svg builds? No, it was for --css-regions and --css-exclusions build, and "upload" option was to a build only bot upload binaries if there isn't tester bot.
Comment on attachment 138068 [details] Patch Clearing flags on attachment: 138068 Committed r114881: <http://trac.webkit.org/changeset/114881>
All reviewed patches have been landed. Closing bug.
Reopen, because it broke the upload buildstep: (view as text) Traceback (most recent call last): File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred result = f(*args, **kw) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 518, in startStep d.addCallback(self._startStep_2) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 298, in addCallback callbackKeywords=kw) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 287, in addCallbacks self._runCallbacks() --- <exception caught here> --- File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 545, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 560, in _startStep_2 setattr(self, renderable, self.build.render(getattr(self, renderable))) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 177, in render return props.render(value) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 137, in render return renderable.getRenderingFor(self) File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 287, in getRenderingFor s = self.fmtstring % pmap exceptions.TypeError: not enough arguments for format string I rolled it out not to cause problem - http://trac.webkit.org/changeset/114886
Mea Culpa, it was a typo. :( Fix is coming soon.
Comment on attachment 138068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138068&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:210 > + masterdest = WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%/%(got_revision)s.zip") typo fix: %(configuration)s%/%(got_revision)s.zip --> %(configuration)s/%(got_revision)s.zip I'm going to land the fixed patch later in an IDLE time of buildmaster not to break bots.
Fixed patch landed in http://trac.webkit.org/changeset/114903
When we re-land thsi, we should add a unittest to validate we don't break Upload again. :)