Bug 84425 – [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId. Implementing this would allow the following test case to be unskipped:
  * security/set-form-autocomplete-attribute.html

[Chris Dumez]

Created attachment 138044 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 138044 [details]
Patch

It looks this patch refers to QT port. Looks fine to me,.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138044&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:114
> +    if (!coreNode || !coreNode->renderer())

Are you sure you need the second check here? None of the methods below seem to use it.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:117
> +    WebCore::HTMLInputElement* inputElement = static_cast< WebCore::HTMLInputElement*>(coreNode);

Style nit: extra space after the opening '<'.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:472
> +    return DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId(mainFrame, id->ustring().utf8().data());

I think it makes sense to construct a String here and pass it as the second parameter to the DRTSupportEfl method:
  const String elementId(id->ustring().impl());

[Chris Dumez]

Created attachment 138295 [details]
Patch

Update patch to take feedback into consideration.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138295&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:119
> +    if (!inputElement)
> +        return false;

Is this condition reachable? The previous if already checks if coreNode is 0.

[Chris Dumez]

Created attachment 138336 [details]
Patch

Yes, you're right. I copied that from the Qt port without paying enough attention.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138336 [details]
Patch

Looks good, thank you.

[WebKit Review Bot]

Comment on attachment 138336 [details]
Patch

Clearing flags on attachment: 138336

Committed r114906: <http://trac.webkit.org/changeset/114906>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.