Bug 84422 - RenderProgress should not need to inherit from RenderBlock
Summary: RenderProgress should not need to inherit from RenderBlock
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-19 21:37 PDT by Eric Seidel (no email)
Modified: 2012-04-20 12:45 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-04-19 21:37:21 PDT 
RenderProgress should not need to inherit from RenderBlock

Same logic as bug 84421.

It has no visible (text) children, and really is just a repalced inline element.  Should likely inherit from RenderReplaced.

progress {
    -webkit-appearance: progress-bar;
    -webkit-box-sizing: border-box;
    display: inline-block;
    height: 1em;
    width: 10em;
    vertical-align: -0.2em;
}

At least that's my understanding.  It does not appear to have rendered children?
Comment 1 Eric Seidel (no email) 2012-04-20 12:44:57 PDT 
After discussion with Hyatt, this needs to be a RenderBlock in order to contain the renderers from its shadow children.
Comment 2 Eric Seidel (no email) 2012-04-20 12:45:17 PDT 
After discussion with Hyatt, this needs to be a RenderBlock in order to contain the renderers from its shadow children.