Bug 84417 – [Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly

[Mark Pilgrim (Google)]

Created attachment 138035 [details]
Patch

[Mark Pilgrim (Google)]

Duplicates some code between ImageChromium.cpp and ImageChromiumMac.mm. Problem?

[Kentaro Hara]

Comment on attachment 138035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138035&action=review

> Duplicates some code between ImageChromium.cpp and ImageChromiumMac.mm. Problem?

Yeah, we want to avoid duplication.

> Source/WebCore/platform/graphics/chromium/ImageChromiumMac.mm:41
> +#include <public/Platform.h>

Nit: This header is duplicated.

[Mark Pilgrim (Google)]

Created attachment 140943 [details]
Patch

[Mark Pilgrim (Google)]

After discussion with abarth, this new patch removes ImageChromiumMac.mm and all references in build scripts, thus eliminating the duplicate code problem.

[Adam Barth]

Comment on attachment 140943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140943&action=review

> Source/WebCore/platform/graphics/chromium/ImageChromium.cpp:51
> +    return image;

image.release();
^^ Transfers the reference from the RefPtr to the PassRefPtr, saving an increment and a decrement on the refcount.

[Mark Pilgrim (Google)]

Created attachment 140988 [details]
Patch

[Mark Pilgrim (Google)]

(In reply to comment #6)
> (From update of attachment 140943 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140943&action=review
> 
> > Source/WebCore/platform/graphics/chromium/ImageChromium.cpp:51
> > +    return image;
> 
> image.release();
> ^^ Transfers the reference from the RefPtr to the PassRefPtr, saving an increment and a decrement on the refcount.

Included in latest patch.

[WebKit Review Bot]

Comment on attachment 140988 [details]
Patch

Clearing flags on attachment: 140988

Committed r116561: <http://trac.webkit.org/changeset/116561>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.