RESOLVED FIXED 84416
Inline the JSArray constructor 
https://bugs.webkit.org/show_bug.cgi?id=84416
Summary Inline the JSArray constructor
Benjamin Poulain
Reported 2012-04-19 20:12:51 PDT
Inline the JSArray constructor, it is trivial, all its parents are inline, and it takes time to jump to it.
Attachments
Patch (2.42 KB, patch)
2012-04-19 20:44 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2012-04-20 11:32 PDT, Benjamin Poulain 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-04-19 20:44:23 PDT
Created attachment 138036 [details] Patch
Build Bot
Comment 2 2012-04-19 21:11:11 PDT
Comment on attachment 138036 [details] Patch Attachment 138036 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12469112
Benjamin Poulain
Comment 3 2012-04-19 23:49:10 PDT
9>jsc.obj : error LNK2005: "protected: __thiscall JSC::JSArray::JSArray(class JSC::JSGlobalData &,class JSC::Structure *)" (??0JSArray@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@@Z) already defined in JavaScriptCore.lib(JavaScriptCore.dll) This is mysterious. Does Windows systematically generate symbols for inlined functions?
Benjamin Poulain
Comment 4 2012-04-20 11:32:10 PDT
Created attachment 138126 [details] Patch
Geoffrey Garen
Comment 5 2012-04-20 15:18:55 PDT
Comment on attachment 138126 [details] Patch r=me
Benjamin Poulain
Comment 6 2012-04-20 15:53:44 PDT
Committed r114793: <http://trac.webkit.org/changeset/114793>
Note You need to log in before you can comment on or make changes to this bug.