Bug 84409 - computeNonFastScrollableRegion needs to traverse the entire frame tree
Summary: computeNonFastScrollableRegion needs to traverse the entire frame tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 84412
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-19 18:11 PDT by Anders Carlsson
Modified: 2012-04-20 15:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2012-04-19 18:13 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-04-19 18:11:20 PDT 
computeNonFastScrollableRegion needs to traverse the entire frame tree
Comment 1 Anders Carlsson 2012-04-19 18:13:13 PDT 
Created attachment 138021 [details]
Patch
Comment 2 James Robinson 2012-04-19 18:21:07 PDT 
Comment on attachment 138021 [details]
Patch

Can you write some tests for this using the numberOfScrollable... hook?
Comment 3 Anders Carlsson 2012-04-19 18:22:27 PDT 
(In reply to comment #2)
> (From update of attachment 138021 [details])
> Can you write some tests for this using the numberOfScrollable... hook?

Unfortunately not, the number of scrollable areas will be the same after this fix, it's just the non-fast-scrollable region that will be different.

We should really figure out a good way to test this :(
Comment 4 mitz 2012-04-19 18:38:47 PDT 
Comment on attachment 138021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138021&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

Please explain why checking for scrollability is no longer needed in this function.
Comment 5 Anders Carlsson 2012-04-19 18:41:09 PDT 
Committed r114711: <http://trac.webkit.org/changeset/114711>
Comment 6 Antonio Gomes 2012-04-19 20:56:45 PDT 
It was rolled out, reopening...
Comment 7 Anders Carlsson 2012-04-20 15:38:58 PDT 
Committed r114792: <http://trac.webkit.org/changeset/114792>