Bug 84398 – Move LayoutTestController::setValueForUser to Internals

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Emil A Eklund]

Move the setValueForUser method from LayoutTestController to Internals.

[Emil A Eklund]

Created attachment 138002 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 138002 [details]
Patch

Attachment 138002 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12482016

[Emil A Eklund]

Not quite sure why the gtk bot doesn't like the change.

[Build Bot]

Comment on attachment 138002 [details]
Patch

Attachment 138002 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12465066

[Hajime Morrita]

Comment on attachment 138002 [details]
Patch

Thanks for taking this! Code looks good. 
r- for bot redness.

GTK bot complains because of missing symbols, which now need to be exported because WebCoreTestSupport is
a separate library from libwebkitgtk. See Source/autotools/symbols.filter.

Windows bot also needs these symbols to be exported. It doesn't have the original DRT implementation
so hasn't done that...

[Emil A Eklund]

(In reply to comment #5)
> (From update of attachment 138002 [details])
> Thanks for taking this! Code looks good. 
> r- for bot redness.
> 
> GTK bot complains because of missing symbols, which now need to be exported because WebCoreTestSupport is
> a separate library from libwebkitgtk. See Source/autotools/symbols.filter.
> 
> Windows bot also needs these symbols to be exported. It doesn't have the original DRT implementation
> so hasn't done that...

Ah, I was guessing it was something like that. Thanks for taking the time to explain it to me!

[Emil A Eklund]

Created attachment 139560 [details]
Patch

[Build Bot]

Comment on attachment 139560 [details]
Patch

Attachment 139560 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12595358

[Emil A Eklund]

Clearly I didn't fix the windows linking problem, lets hope I got the gtk one though.

[Philippe Normand]

Comment on attachment 139560 [details]
Patch

Attachment 139560 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12593421

[Hajime Morrita]

Comment on attachment 139560 [details]
Patch

(In reply to comment #9)
> Clearly I didn't fix the windows linking problem, lets hope I got the gtk one though.
Your hope didn't come. Good news is that the error message is clear.

  CXXLD  libwebkitgtk-3.0.la
/usr/bin/ld.gold.real: error: ../../Source/autotools/symbols.filter:59:1: syntax error, unexpected STRING, expecting ';'
/usr/bin/ld.gold.real: fatal error: unable to parse version script file ../../Source/autotools/symbols.filter
collect2: ld returned 1 exit status

[Andre Loureiro (IRC: loureiro)]

Hi, since there's no one working on this issue I'd like to assign this one to me

[Zan Dobersek]

No problem.

[Andre Loureiro (IRC: loureiro)]

Created attachment 214175 [details]
Proposed Patch

Hi, attached my proposed patch, and could not mark the second one as obsolete.

[Build Bot]

Comment on attachment 214175 [details]
Proposed Patch

Attachment 214175 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3949842

[Andre Loureiro (IRC: loureiro)]

Created attachment 214182 [details]
Proposed Patch

Updated patch

[Build Bot]

Comment on attachment 214182 [details]
Proposed Patch

Attachment 214182 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3952872

[Darin Adler]

Comment on attachment 214182 [details]
Proposed Patch

Looks like Windows needs an update to an .exp file:

     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: void __thiscall WebCore::HTMLInputElement::setValueForUser(class WTF::String const &)" (?setValueForUser@HTMLInputElement@WebCore@@QAEXABVString@WTF@@@Z) referenced in function "public: void __thiscall WebCore::Internals::setValueForUser(class WebCore::Element *,class WTF::String const &,int &)" (?setValueForUser@Internals@WebCore@@QAEXPAVElement@2@ABVString@WTF@@AAH@Z)

r=me as long as you fix that

[Andre Loureiro (IRC: loureiro)]

Created attachment 214261 [details]
WIP Patch for EWS test

Just for testing WIN build

[Build Bot]

Comment on attachment 214261 [details]
WIP Patch for EWS test

Attachment 214261 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4099052

[Build Bot]

Comment on attachment 214261 [details]
WIP Patch for EWS test

Attachment 214261 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4065108

[Build Bot]

Comment on attachment 214261 [details]
WIP Patch for EWS test

Attachment 214261 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/4097043

[Andre Loureiro (IRC: loureiro)]

Created attachment 214360 [details]
WIP Patch for EWS testing

Patch for EWS analysis

[Andre Loureiro (IRC: loureiro)]

Created attachment 214386 [details]
Patch

[Andre Loureiro (IRC: loureiro)]

Darin, any update?