Bug 84398 - Move LayoutTestController::setValueForUser to Internals
Summary: Move LayoutTestController::setValueForUser to Internals
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andre Loureiro (IRC: loureiro)
URL:
Keywords:
Depends on: 87993
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-19 16:15 PDT by Emil A Eklund
Modified: 2022-03-01 02:56 PST (History)
16 users (show)

See Also:

Attachments
Patch (26.24 KB, patch)
2012-04-19 16:29 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (27.74 KB, patch)
2012-04-30 18:08 PDT, Emil A Eklund 		morrita: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (20.03 KB, patch)
2013-10-14 11:57 PDT, Andre Loureiro (IRC: loureiro) 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (20.03 KB, patch)
2013-10-14 12:40 PDT, Andre Loureiro (IRC: loureiro) 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
WIP Patch for EWS test (21.05 KB, patch)
2013-10-15 08:31 PDT, Andre Loureiro (IRC: loureiro) 		buildbot: commit-queue-
Details | Formatted Diff | Diff
WIP Patch for EWS testing (21.90 KB, patch)
2013-10-16 06:59 PDT, Andre Loureiro (IRC: loureiro) 		no flags Details | Formatted Diff | Diff
Patch (22.02 KB, patch)
2013-10-16 12:49 PDT, Andre Loureiro (IRC: loureiro) 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-04-19 16:15:15 PDT 
Move the setValueForUser method from LayoutTestController to Internals.
Comment 1 Emil A Eklund 2012-04-19 16:29:58 PDT 
Created attachment 138002 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-04-19 16:41:02 PDT 
Comment on attachment 138002 [details]
Patch

Attachment 138002 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12482016
Comment 3 Emil A Eklund 2012-04-19 16:49:11 PDT 
Not quite sure why the gtk bot doesn't like the change.
Comment 4 Build Bot 2012-04-19 17:30:02 PDT 
Comment on attachment 138002 [details]
Patch

Attachment 138002 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12465066
Comment 5 Hajime Morrita 2012-04-23 10:15:12 PDT 
Comment on attachment 138002 [details]
Patch

Thanks for taking this! Code looks good. 
r- for bot redness.

GTK bot complains because of missing symbols, which now need to be exported because WebCoreTestSupport is
a separate library from libwebkitgtk. See Source/autotools/symbols.filter.

Windows bot also needs these symbols to be exported. It doesn't have the original DRT implementation
so hasn't done that...
Comment 6 Emil A Eklund 2012-04-23 10:18:40 PDT 
(In reply to comment #5)
> (From update of attachment 138002 [details])
> Thanks for taking this! Code looks good. 
> r- for bot redness.
> 
> GTK bot complains because of missing symbols, which now need to be exported because WebCoreTestSupport is
> a separate library from libwebkitgtk. See Source/autotools/symbols.filter.
> 
> Windows bot also needs these symbols to be exported. It doesn't have the original DRT implementation
> so hasn't done that...

Ah, I was guessing it was something like that. Thanks for taking the time to explain it to me!
Comment 7 Emil A Eklund 2012-04-30 18:08:43 PDT 
Created attachment 139560 [details]
Patch
Comment 8 Build Bot 2012-04-30 18:45:40 PDT 
Comment on attachment 139560 [details]
Patch

Attachment 139560 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12595358
Comment 9 Emil A Eklund 2012-04-30 18:47:20 PDT 
Clearly I didn't fix the windows linking problem, lets hope I got the gtk one though.
Comment 10 Philippe Normand 2012-04-30 18:49:29 PDT 
Comment on attachment 139560 [details]
Patch

Attachment 139560 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12593421
Comment 11 Hajime Morrita 2012-05-01 02:11:20 PDT 
Comment on attachment 139560 [details]
Patch

(In reply to comment #9)
> Clearly I didn't fix the windows linking problem, lets hope I got the gtk one though.
Your hope didn't come. Good news is that the error message is clear.

  CXXLD  libwebkitgtk-3.0.la
/usr/bin/ld.gold.real: error: ../../Source/autotools/symbols.filter:59:1: syntax error, unexpected STRING, expecting ';'
/usr/bin/ld.gold.real: fatal error: unable to parse version script file ../../Source/autotools/symbols.filter
collect2: ld returned 1 exit status
Comment 12 Andre Loureiro (IRC: loureiro) 2013-10-14 11:42:38 PDT 
Hi, since there's no one working on this issue I'd like to assign this one to me
Comment 13 Zan Dobersek 2013-10-14 11:46:31 PDT 
No problem.
Comment 14 Andre Loureiro (IRC: loureiro) 2013-10-14 11:57:21 PDT 
Created attachment 214175 [details]
Proposed Patch

Hi, attached my proposed patch, and could not mark the second one as obsolete.
Comment 15 Build Bot 2013-10-14 12:36:47 PDT 
Comment on attachment 214175 [details]
Proposed Patch

Attachment 214175 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3949842
Comment 16 Andre Loureiro (IRC: loureiro) 2013-10-14 12:40:42 PDT 
Created attachment 214182 [details]
Proposed Patch

Updated patch
Comment 17 Build Bot 2013-10-14 13:19:59 PDT 
Comment on attachment 214182 [details]
Proposed Patch

Attachment 214182 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3952872
Comment 18 Darin Adler 2013-10-14 16:00:17 PDT 
Comment on attachment 214182 [details]
Proposed Patch

Looks like Windows needs an update to an .exp file:

     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: void __thiscall WebCore::HTMLInputElement::setValueForUser(class WTF::String const &)" (?setValueForUser@HTMLInputElement@WebCore@@QAEXABVString@WTF@@@Z) referenced in function "public: void __thiscall WebCore::Internals::setValueForUser(class WebCore::Element *,class WTF::String const &,int &)" (?setValueForUser@Internals@WebCore@@QAEXPAVElement@2@ABVString@WTF@@AAH@Z)

r=me as long as you fix that
Comment 19 Andre Loureiro (IRC: loureiro) 2013-10-15 08:31:01 PDT 
Created attachment 214261 [details]
WIP Patch for EWS test

Just for testing WIN build
Comment 20 Build Bot 2013-10-15 09:01:36 PDT 
Comment on attachment 214261 [details]
WIP Patch for EWS test

Attachment 214261 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4099052
Comment 21 Build Bot 2013-10-15 09:06:43 PDT 
Comment on attachment 214261 [details]
WIP Patch for EWS test

Attachment 214261 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4065108
Comment 22 Build Bot 2013-10-15 09:21:24 PDT 
Comment on attachment 214261 [details]
WIP Patch for EWS test

Attachment 214261 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/4097043
Comment 23 Andre Loureiro (IRC: loureiro) 2013-10-16 06:59:22 PDT 
Created attachment 214360 [details]
WIP Patch for EWS testing

Patch for EWS analysis
Comment 24 Andre Loureiro (IRC: loureiro) 2013-10-16 12:49:15 PDT 
Created attachment 214386 [details]
Patch
Comment 25 Andre Loureiro (IRC: loureiro) 2013-10-17 11:40:14 PDT 
Darin, any update?