RESOLVED FIXED 84391
Set m_compositingDependsOnGeometry to false if possible 
https://bugs.webkit.org/show_bug.cgi?id=84391
Summary Set m_compositingDependsOnGeometry to false if possible
Simon Fraser (smfr)
Reported 2012-04-19 15:34:17 PDT
RenderLayerCompositor sets the m_compositingDependsOnGeometry flag if it needs to wait until after layout is done before making compositing decisions. This is used for iframes and plugins. m_compositingNeedsUpdate was added for fixed position, but I think plays a similar role. Also, m_compositingDependsOnGeometry is never set to 'false' after being set, so we end up doing expensive computeCompositingRequirements() checks every time.
Attachments
Patch (13.22 KB, patch)
2012-04-19 17:59 PDT, Simon Fraser (smfr) 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-04-19 17:59:46 PDT
Created attachment 138016 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-04-19 18:00:33 PDT
James/Vangelis: Can I trust the Chromium EWS to tell me if this broke compositing for position:fixed?
Vangelis Kokkevis
Comment 3 2012-04-20 12:58:35 PDT
(In reply to comment #2) > James/Vangelis: Can I trust the Chromium EWS to tell me if this broke compositing for position:fixed? I'm not sure if fixed-position-composited-switch.html (the test that was added to test fixedpos compositing) tests the case where we don't quite have enough information to decide on whether to composite or not and we have to repeat after layout. In any case, the basic functionality seems to work fine after your change so we should be ok.
James Robinson
Comment 4 2012-04-20 14:45:30 PDT
Comment on attachment 138016 [details] Patch Awesome! R=me
Simon Fraser (smfr)
Comment 5 2012-04-20 14:55:01 PDT
http://trac.webkit.org/changeset/114785
Note You need to log in before you can comment on or make changes to this bug.