Bug 84382 - New ruby tests broken on Mac
: New ruby tests broken on Mac
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-19 14:23 PST by
Modified: 2012-04-19 19:00 PST (History)


Attachments
Patch (4.68 KB, patch)
2012-04-19 14:49 PST, Ken Buchanan
no flags Review Patch | Details | Formatted Diff | Diff
Patch (4.63 KB, patch)
2012-04-19 14:54 PST, Ken Buchanan
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-19 14:23:50 PST
Two new tests that recently landed are failing with text diffs on Mac: http://trac.webkit.org/changeset/114666

There is a one pixel height difference. Apparently I need a minor tweak to make these tests work cross-platform with the same results.

http://build.webkit.org/results/Lion%20Release%20(Tests)/r114666%20(7766)/results.html
------- Comment #1 From 2012-04-19 14:49:24 PST -------
Created an attachment (id=137981) [details]
Patch
------- Comment #2 From 2012-04-19 14:54:23 PST -------
Created an attachment (id=137983) [details]
Patch
------- Comment #3 From 2012-04-19 14:55:16 PST -------
Patch update is just because I accidentally had +x on the expectation files.
------- Comment #4 From 2012-04-19 15:02:18 PST -------
smfr can you review this?
------- Comment #5 From 2012-04-19 15:10:19 PST -------
Is this equivalent to what jer did in http://trac.webkit.org/changeset/114674?
------- Comment #6 From 2012-04-19 15:12:01 PST -------
(From update of attachment 137983 [details])
OK.
------- Comment #7 From 2012-04-19 15:49:22 PST -------
(From update of attachment 137983 [details])
Clearing flags on attachment: 137983

Committed r114685: <http://trac.webkit.org/changeset/114685>
------- Comment #8 From 2012-04-19 15:49:28 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #9 From 2012-04-19 18:29:10 PST -------
Ugh, I didn't see http://trac.webkit.org/changeset/114674 go in. That provides new Mac baselines, but I updated the tests to provide non-platform specific results. This will be fixed if 114674 gets rolled out, it looks like.

The actual results match the expectations I provided in my patch:
http://build.webkit.org/results/Lion%20Release%20%28Tests%29/r114685%20%287772%29/results.html
------- Comment #10 From 2012-04-19 19:00:58 PST -------
ugh, I need to fix mine as well: http://trac.webkit.org/changeset/114701