WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 84382
New ruby tests broken on Mac
https://bugs.webkit.org/show_bug.cgi?id=84382
Summary
New ruby tests broken on Mac
Ken Buchanan
Reported
2012-04-19 14:23:50 PDT
Two new tests that recently landed are failing with text diffs on Mac:
http://trac.webkit.org/changeset/114666
There is a one pixel height difference. Apparently I need a minor tweak to make these tests work cross-platform with the same results.
http://build.webkit.org/results/Lion%20Release%20(Tests)/r114666%20(7766)/results.html
Attachments
Patch
(4.68 KB, patch)
2012-04-19 14:49 PDT
,
Ken Buchanan
no flags
Details
Formatted Diff
Diff
Patch
(4.63 KB, patch)
2012-04-19 14:54 PDT
,
Ken Buchanan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ken Buchanan
Comment 1
2012-04-19 14:49:24 PDT
Created
attachment 137981
[details]
Patch
Ken Buchanan
Comment 2
2012-04-19 14:54:23 PDT
Created
attachment 137983
[details]
Patch
Ken Buchanan
Comment 3
2012-04-19 14:55:16 PDT
Patch update is just because I accidentally had +x on the expectation files.
Ken Buchanan
Comment 4
2012-04-19 15:02:18 PDT
smfr can you review this?
Simon Fraser (smfr)
Comment 5
2012-04-19 15:10:19 PDT
Is this equivalent to what jer did in
http://trac.webkit.org/changeset/114674
?
Eric Seidel (no email)
Comment 6
2012-04-19 15:12:01 PDT
Comment on
attachment 137983
[details]
Patch OK.
WebKit Review Bot
Comment 7
2012-04-19 15:49:22 PDT
Comment on
attachment 137983
[details]
Patch Clearing flags on attachment: 137983 Committed
r114685
: <
http://trac.webkit.org/changeset/114685
>
WebKit Review Bot
Comment 8
2012-04-19 15:49:28 PDT
All reviewed patches have been landed. Closing bug.
Ken Buchanan
Comment 9
2012-04-19 18:29:10 PDT
Ugh, I didn't see
http://trac.webkit.org/changeset/114674
go in. That provides new Mac baselines, but I updated the tests to provide non-platform specific results. This will be fixed if 114674 gets rolled out, it looks like. The actual results match the expectations I provided in my patch:
http://build.webkit.org/results/Lion%20Release%20%28Tests%29/r114685%20%287772%29/results.html
Dmitry Titov
Comment 10
2012-04-19 19:00:58 PDT
ugh, I need to fix mine as well:
http://trac.webkit.org/changeset/114701
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug