Bug 84373 – [chromium] Some filters require inflating damage rect in CCDamageTracker

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Blur should move damage around in the blurred layer

[Dana Jansens]

Created attachment 137956 [details]
Patch

[Shawn Singh]

Comment on attachment 137956 [details]
Patch


Just a few trivial nits on my part.

Otherwise it LGTM.


View in context: https://bugs.webkit.org/attachment.cgi?id=137956&action=review

> Source/WebCore/ChangeLog:3
> +        [chromium] Blur should move damage around in the blurred layer

Could we re-title this to "Filters may need to inflate damage rect in CCDamageTracker"

> Source/WebCore/ChangeLog:9
> +        and their damage should be moved along with them.

perhaps  s/moved along with them/expanded to include total blurred region  ??

> Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:147
> +        // Filters can spread damage around in the surface.
> +        if (filters.hasFilterThatMovesPixels()) {
> +            int top, right, bottom, left;
> +            filters.getOutsets(top, right, bottom, left);
> +            m_currentDamageRect.move(-left, -top);
> +            m_currentDamageRect.expand(left + right, top + bottom);
> +        }

Can we make this into a helper function like  "expandDamageRectIfNeeded()"

> Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:336
> +    // Damage position on the surface should be: position of updateRect (10, 11) relative to the child (100, 100), but blurred out by the blur outsets.

s/blurred out/expanded

[Dana Jansens]

Comment on attachment 137956 [details]
Patch

Thanks for looking at this Shawn. Will update the patch in the morning.

[Dana Jansens]

Created attachment 138099 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138099 [details]
Patch

Clearing flags on attachment: 138099

Committed r114763: <http://trac.webkit.org/changeset/114763>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.