Bug 84369 - Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
Summary: Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-19 12:19 PDT by Luke Macpherson
Modified: 2012-04-19 14:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2012-04-19 12:19 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-04-19 12:19:05 PDT 
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
Comment 1 Luke Macpherson 2012-04-19 12:19:58 PDT 
Created attachment 137948 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-19 14:22:27 PDT 
Comment on attachment 137948 [details]
Patch

I'm confused.  The old code was setting value every time?  Making the value = valueList->next() never do anything?
Comment 3 Luke Macpherson 2012-04-19 14:39:13 PDT 
The old code calls value = value->current() for every iteration, which is unnecessary because the value->current() is the same as the previous assignment from value->next().
Comment 4 WebKit Review Bot 2012-04-19 14:57:15 PDT 
Comment on attachment 137948 [details]
Patch

Clearing flags on attachment: 137948

Committed r114676: <http://trac.webkit.org/changeset/114676>
Comment 5 WebKit Review Bot 2012-04-19 14:57:20 PDT 
All reviewed patches have been landed.  Closing bug.