RESOLVED FIXED 84369
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()). 
https://bugs.webkit.org/show_bug.cgi?id=84369
Summary Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls...
Luke Macpherson
Reported 2012-04-19 12:19:05 PDT
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
Attachments
Patch (1.78 KB, patch)
2012-04-19 12:19 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-04-19 12:19:58 PDT
Created attachment 137948 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-19 14:22:27 PDT
Comment on attachment 137948 [details] Patch I'm confused. The old code was setting value every time? Making the value = valueList->next() never do anything?
Luke Macpherson
Comment 3 2012-04-19 14:39:13 PDT
The old code calls value = value->current() for every iteration, which is unnecessary because the value->current() is the same as the previous assignment from value->next().
WebKit Review Bot
Comment 4 2012-04-19 14:57:15 PDT
Comment on attachment 137948 [details] Patch Clearing flags on attachment: 137948 Committed r114676: <http://trac.webkit.org/changeset/114676>
WebKit Review Bot
Comment 5 2012-04-19 14:57:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.