Bug 84358 - Web Inspector: exception when hovering object while paused
Summary: Web Inspector: exception when hovering object while paused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-19 11:06 PDT by Yury Semikhatsky
Modified: 2012-04-19 11:18 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.46 KB, patch)
2012-04-19 11:09 PDT, Yury Semikhatsky
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-04-19 11:06:46 PDT
"Protocol Error: Invalid type of argument 'returnByValue' for method 'Debugger.evaluateOnCallFrame' call. It must be 'boolean' but it is 'function'.", source: chrome-devtools://devtools/InspectorBackend.js (113)
Comment 1 Yury Semikhatsky 2012-04-19 11:09:54 PDT
Created attachment 137924 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-04-19 11:11:39 PDT
Comment on attachment 137924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137924&action=review

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:283
> +        selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, false, showObjectPopover.bind(this));

It should be true.
Comment 3 Yury Semikhatsky 2012-04-19 11:13:05 PDT
(In reply to comment #2)
> (From update of attachment 137924 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137924&action=review
> 
> > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:283
> > +        selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, false, showObjectPopover.bind(this));
> 
> It should be true.

Done.
Comment 4 Yury Semikhatsky 2012-04-19 11:18:26 PDT
Committed r114654: <http://trac.webkit.org/changeset/114654>