Bug 84340 – [EFL] tabsToLinks ewk_view setting

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

ewk_view should expose tabsToLinks, hyperlinkAuditingEnabled, webGLEnabled settings in order to provide EFL's LayoutTestController overridePreference implementation.

[Mikhail Pozdnyakov]

Created attachment 137934 [details]
adding ewk_view settings

Exporting 3 new ewk_view settings:
1) hyperlinkAuditingEnabled - enbles/desables hyperlink auditing (http://www.whatwg.org/specs/web-apps/current-work/#hyperlink-auditing). 
2) tabsToLinks - sets whether the tab key will focus links and form controls.
3) webGLEnabled - run-time flag for WebGL.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 137934 [details]
adding ewk_view settings

Theoretically speaking, these three settings are unrelated to each other so it makes sense to submit separate patches for them. Please explain in the documentation what the default for each setting is, and expand a little on what they are used for (an API user probably won't know what hyperlink auditing means, for example).

[Mikhail Pozdnyakov]

(In reply to comment #0)
> ewk_view should expose tabsToLinks, hyperlinkAuditingEnabled, webGLEnabled settings in order to provide EFL's LayoutTestController overridePreference implementation.

Splitting it. This bug is responsible for tabsToLinks ewk_view setting only.

[Mikhail Pozdnyakov]

Created attachment 138237 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138237 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

View in context: https://bugs.webkit.org/attachment.cgi?id=138237&action=review

The change looks OK, but the function names still rub me in the wrong way. Both Qt and GTK+ seem to use "links included in focus chain" to describe this feature; perhaps ewk_view_setting_include_links_in_focus_chain_{get,set} makes more sense?

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:309
> +    return ewk_view_setting_enable_tabs_to_links_get(m_view) ? KeyboardAccessTabsToLinks: KeyboardAccessDefault;

Minor nit: please add a space character before the ':'.

[Mikhail Pozdnyakov]

Created attachment 138273 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

rename setter and getter functions, added space.

[Gyuyoung Kim]

Comment on attachment 138273 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Attachment 138273 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12482668

[Mikhail Pozdnyakov]

Created attachment 138274 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

[Mikhail Pozdnyakov]

Created attachment 138275 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138275 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Looks good, thanks.

[WebKit Review Bot]

Comment on attachment 138275 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Rejecting attachment 138275 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
git/webkit-commit-queue/Source/WebKit/chromium/ui --revision 133673 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 133673.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12527894

[Mikhail Pozdnyakov]

Created attachment 139183 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased)

[Mikhail Pozdnyakov]

Created attachment 139184 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased)

[WebKit Review Bot]

Comment on attachment 139184 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased)

Clearing flags on attachment: 139184

Committed r115449: <http://trac.webkit.org/changeset/115449>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.