Bug 84340 - [EFL] tabsToLinks ewk_view setting
Summary: [EFL] tabsToLinks ewk_view setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 83007
  Show dependency treegraph
 
Reported: 2012-04-19 07:40 PDT by Mikhail Pozdnyakov
Modified: 2012-05-22 11:10 PDT (History)
4 users (show)

See Also:


Attachments
adding ewk_view settings (9.40 KB, patch)
2012-04-19 11:42 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (5.07 KB, patch)
2012-04-21 09:40 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (5.12 KB, patch)
2012-04-22 14:26 PDT, Mikhail Pozdnyakov
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (34.92 KB, patch)
2012-04-22 14:46 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (5.12 KB, patch)
2012-04-22 14:51 PDT, Mikhail Pozdnyakov
tonikitoo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased) (5.12 KB, patch)
2012-04-27 06:10 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased) (5.05 KB, patch)
2012-04-27 06:13 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-04-19 07:40:03 PDT
ewk_view should expose tabsToLinks, hyperlinkAuditingEnabled, webGLEnabled settings in order to provide EFL's LayoutTestController overridePreference implementation.
Comment 1 Mikhail Pozdnyakov 2012-04-19 11:42:45 PDT
Created attachment 137934 [details]
adding ewk_view settings

Exporting 3 new ewk_view settings:
1) hyperlinkAuditingEnabled - enbles/desables hyperlink auditing (http://www.whatwg.org/specs/web-apps/current-work/#hyperlink-auditing). 
2) tabsToLinks - sets whether the tab key will focus links and form controls.
3) webGLEnabled - run-time flag for WebGL.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-04-19 12:28:40 PDT
Comment on attachment 137934 [details]
adding ewk_view settings

Theoretically speaking, these three settings are unrelated to each other so it makes sense to submit separate patches for them. Please explain in the documentation what the default for each setting is, and expand a little on what they are used for (an API user probably won't know what hyperlink auditing means, for example).
Comment 3 Mikhail Pozdnyakov 2012-04-20 00:16:51 PDT
(In reply to comment #0)
> ewk_view should expose tabsToLinks, hyperlinkAuditingEnabled, webGLEnabled settings in order to provide EFL's LayoutTestController overridePreference implementation.

Splitting it. This bug is responsible for tabsToLinks ewk_view setting only.
Comment 4 Mikhail Pozdnyakov 2012-04-21 09:40:04 PDT
Created attachment 138237 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-04-21 14:57:16 PDT
Comment on attachment 138237 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

View in context: https://bugs.webkit.org/attachment.cgi?id=138237&action=review

The change looks OK, but the function names still rub me in the wrong way. Both Qt and GTK+ seem to use "links included in focus chain" to describe this feature; perhaps ewk_view_setting_include_links_in_focus_chain_{get,set} makes more sense?

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:309
> +    return ewk_view_setting_enable_tabs_to_links_get(m_view) ? KeyboardAccessTabsToLinks: KeyboardAccessDefault;

Minor nit: please add a space character before the ':'.
Comment 6 Mikhail Pozdnyakov 2012-04-22 14:26:29 PDT
Created attachment 138273 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

rename setter and getter functions, added space.
Comment 7 Gyuyoung Kim 2012-04-22 14:32:35 PDT
Comment on attachment 138273 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Attachment 138273 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12482668
Comment 8 Mikhail Pozdnyakov 2012-04-22 14:46:45 PDT
Created attachment 138274 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.
Comment 9 Mikhail Pozdnyakov 2012-04-22 14:51:17 PDT
Created attachment 138275 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.
Comment 10 Raphael Kubo da Costa (:rakuco) 2012-04-22 14:56:24 PDT
Comment on attachment 138275 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Looks good, thanks.
Comment 11 WebKit Review Bot 2012-04-26 07:01:11 PDT
Comment on attachment 138275 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Rejecting attachment 138275 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
git/webkit-commit-queue/Source/WebKit/chromium/ui --revision 133673 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 133673.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12527894
Comment 12 Mikhail Pozdnyakov 2012-04-27 06:10:26 PDT
Created attachment 139183 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased)
Comment 13 Mikhail Pozdnyakov 2012-04-27 06:13:45 PDT
Created attachment 139184 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased)
Comment 14 WebKit Review Bot 2012-04-27 11:00:27 PDT
Comment on attachment 139184 [details]
Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements. (reviewed rebased)

Clearing flags on attachment: 139184

Committed r115449: <http://trac.webkit.org/changeset/115449>
Comment 15 WebKit Review Bot 2012-04-27 11:00:33 PDT
All reviewed patches have been landed.  Closing bug.