Bug 84334 - [Chromium] Call mimeRegistry directly
Summary: [Chromium] Call mimeRegistry directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-04-19 06:46 PDT by Mark Pilgrim (Google)
Modified: 2012-04-19 09:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.11 KB, patch)
2012-04-19 06:48 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (8.08 KB, patch)
2012-04-19 08:02 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-04-19 06:46:11 PDT
[Chromium] Call mimeRegistry directly
Comment 1 Mark Pilgrim (Google) 2012-04-19 06:48:21 PDT
Created attachment 137895 [details]
Patch
Comment 2 Kentaro Hara 2012-04-19 07:24:36 PDT
Comment on attachment 137895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137895&action=review

> Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp:68
> -    String ext = PlatformSupport::preferredExtensionForMIMEType(type);
> +    String ext = WebKit::Platform::current()->mimeRegistry()->mimeTypeFromFile(type);

This is wrong?
Comment 3 Mark Pilgrim (Google) 2012-04-19 08:02:07 PDT
Created attachment 137904 [details]
Patch
Comment 4 Mark Pilgrim (Google) 2012-04-19 08:03:21 PDT
(In reply to comment #2)
> (From update of attachment 137895 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137895&action=review
> 
> > Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp:68
> > -    String ext = PlatformSupport::preferredExtensionForMIMEType(type);
> > +    String ext = WebKit::Platform::current()->mimeRegistry()->mimeTypeFromFile(type);
> 
> This is wrong?

Oops, fixed.
Comment 5 WebKit Review Bot 2012-04-19 09:40:44 PDT
Comment on attachment 137904 [details]
Patch

Clearing flags on attachment: 137904

Committed r114641: <http://trac.webkit.org/changeset/114641>
Comment 6 WebKit Review Bot 2012-04-19 09:40:49 PDT
All reviewed patches have been landed.  Closing bug.