RESOLVED FIXED 84334
[Chromium] Call mimeRegistry directly 
https://bugs.webkit.org/show_bug.cgi?id=84334
Summary [Chromium] Call mimeRegistry directly
Mark Pilgrim (Google)
Reported 2012-04-19 06:46:11 PDT
[Chromium] Call mimeRegistry directly
Attachments
Patch (8.11 KB, patch)
2012-04-19 06:48 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (8.08 KB, patch)
2012-04-19 08:02 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-04-19 06:48:21 PDT
Created attachment 137895 [details] Patch
Kentaro Hara
Comment 2 2012-04-19 07:24:36 PDT
Comment on attachment 137895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137895&action=review > Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp:68 > - String ext = PlatformSupport::preferredExtensionForMIMEType(type); > + String ext = WebKit::Platform::current()->mimeRegistry()->mimeTypeFromFile(type); This is wrong?
Mark Pilgrim (Google)
Comment 3 2012-04-19 08:02:07 PDT
Created attachment 137904 [details] Patch
Mark Pilgrim (Google)
Comment 4 2012-04-19 08:03:21 PDT
(In reply to comment #2) > (From update of attachment 137895 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137895&action=review > > > Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp:68 > > - String ext = PlatformSupport::preferredExtensionForMIMEType(type); > > + String ext = WebKit::Platform::current()->mimeRegistry()->mimeTypeFromFile(type); > > This is wrong? Oops, fixed.
WebKit Review Bot
Comment 5 2012-04-19 09:40:44 PDT
Comment on attachment 137904 [details] Patch Clearing flags on attachment: 137904 Committed r114641: <http://trac.webkit.org/changeset/114641>
WebKit Review Bot
Comment 6 2012-04-19 09:40:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.