Bug 84331 - Web Inspector: introduce styles panel as an experiment
Summary: Web Inspector: introduce styles panel as an experiment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-19 05:40 PDT by Pavel Feldman
Modified: 2012-04-19 09:20 PDT (History)
10 users (show)

See Also:

Attachments
Patch (25.74 KB, patch)
2012-04-19 05:44 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-19 05:40:46 PDT 
This change introduces new "Styles" panel that looks like the "Scripts" one, but operates only stylesheets. This is happening under the experimental flag.
Comment 1 Pavel Feldman 2012-04-19 05:44:04 PDT 
Created attachment 137885 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-04-19 08:13:54 PDT 
Comment on attachment 137885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137885&action=review

> Source/WebCore/inspector/front-end/StylesPanel.js:51
> +    this._navigatorView = this._navigator.view;

Is this field needed?

> Source/WebCore/inspector/front-end/StylesPanel.js:69
> +

Please remove this line.

> Source/WebCore/inspector/front-end/StylesPanel.js:154
> +        var sourceFrame = this._showFile(uiSourceCode);

_showFile does not return anything. Did you mean:
this._showFile(uiSourceCode);
var sourceFrame = this._sourceFramesForResource.get(uiSourceCode);
Comment 3 Pavel Feldman 2012-04-19 09:20:16 PDT 
Committed r114637: <http://trac.webkit.org/changeset/114637>