Bug 84328 – Media Stream API: Piece of code cleanup for the chromium port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Jeremy Mao]

Created attachment 137877 [details]
Patch

Remove some dead code, please see the attachment.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 137877 [details]
Patch

Attachment 137877 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12297282

[Jeremy Mao]

Created attachment 137880 [details]
Patch

[Jeremy Mao]

Created attachment 137881 [details]
Patch

Fix a typo

[Kent Tamura]

Comment on attachment 137881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137881&action=review

> Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h:53
> +    virtual void requestUserMedia(const WebUserMediaRequest&, const WebVector<WebMediaStreamSource>&, const WebVector<WebMediaStreamSource>&);

We had better append 'OVERRIDE' to this.

[Jeremy Mao]

Created attachment 138023 [details]
Patch

[Jeremy Mao]

(In reply to comment #5)
> (From update of attachment 137881 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137881&action=review
> 
> > Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h:53
> > +    virtual void requestUserMedia(const WebUserMediaRequest&, const WebVector<WebMediaStreamSource>&, const WebVector<WebMediaStreamSource>&);
> 
> We had better append 'OVERRIDE' to this.
Fixed

[Kent Tamura]

Comment on attachment 137881 [details]
Patch

please use "webkit-patch upload" to upload a patch.

[WebKit Review Bot]

Comment on attachment 138023 [details]
Patch

Rejecting attachment 138023 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
r_text(self._author_text)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 156, in _parse_author_text
    return [ChangeLogEntry._parse_author_name_and_email(author) for author in authors]
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 148, in _parse_author_name_and_email
    return {'name': match.group("name"), 'email': match.group("email")}
AttributeError: 'NoneType' object has no attribute 'group'

Full output: http://queues.webkit.org/results/12460092

[Jeremy Mao]

Created attachment 138026 [details]
Patch

[Kent Tamura]

Comment on attachment 138026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138026&action=review

> Source/WebKit/chromium/ChangeLog:1
> [phone]  Mao, Yujie  <[e-mail]>

Unfortunately our tool doesn't accept ',' in a person name.

[Eric Seidel (no email)]

Looks like a bug in webkitpy's ChangeLog handling code.

[Jeremy Mao]

(In reply to comment #11)
> (From update of attachment 138026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138026&action=review
> 
> > Source/WebKit/chromium/ChangeLog:1
> > [phone]  Mao, Yujie  <[e-mail]>
> 
> Unfortunately our tool doesn't accept ',' in a person name.

:) It's ok, I will remove ',' in my name.

[Jeremy Mao]

Created attachment 138030 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138030 [details]
Patch

Clearing flags on attachment: 138030

Committed r114714: <http://trac.webkit.org/changeset/114714>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.