The DRT-Qt port creates pixel dumps even for test cases where this is not expected. I.e.: ./Tools/Scripts/run-webkit-tests -p LayoutTests/printing/page-break-orphans.html -> creates a PNG of the page and complains about missing baseline According to Dirk Pranke (https://lists.webkit.org/pipermail/webkit-dev/2012-April/020349.html) pixel dumps should not be created when layoutTestController.dumpAsText() was called. The attached patch does that and fixes the problem mentioned above.
Created attachment 137875 [details] don't dump pixels if shouldDumpAsText is true patch that checks m_controller->shouldDumpAsText() and prevents the pixel-dump when that is true
Comment on attachment 137875 [details] don't dump pixels if shouldDumpAsText is true View in context: https://bugs.webkit.org/attachment.cgi?id=137875&action=review Only small nitpicks, otherwise LGTM. Please update the patch and upload it with r? > Tools/ChangeLog:5 > + Qt: don't dump pixels if test should be dumped as text > + > + [Qt] don't dump pixels if test should be dumped as text Could you add the title (the new one, please) only once to the changelog? > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:951 > // FIXME: All other ports don't dump pixels, if generatePixelResults is false. Please remove this FIXME, we don't need anymore after your fix.
Created attachment 137886 [details] don't dump pixels if shouldDumpAsText is true fix issues raised by Ossy
Comment on attachment 137886 [details] don't dump pixels if shouldDumpAsText is true View in context: https://bugs.webkit.org/attachment.cgi?id=137886&action=review Something is wrong with Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp, because it can't be applied. > Tools/ChangeLog:5 > + [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText() > + > + Reviewed by NOBODY (OOPS!). [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText() https://bugs.webkit.org/show_bug.cgi?id=84327 Reviewed by NOBODY (OOPS!).
Created attachment 137893 [details] don't dump pixels if shouldDumpAsText is true - create patch that directly applies against master - add bug url to changelog entry
Comment on attachment 137893 [details] don't dump pixels if shouldDumpAsText is true LGTM, r=me.
Comment on attachment 137893 [details] don't dump pixels if shouldDumpAsText is true Clearing flags on attachment: 137893 Committed r114875: <http://trac.webkit.org/changeset/114875>
All reviewed patches have been landed. Closing bug.