Bug 84318 - AsyncFileSystem::openFileSystem is missing parameters
Summary: AsyncFileSystem::openFileSystem is missing parameters
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 82156
  Show dependency tree / graph
 
Reported: 2012-04-18 22:49 PDT by Leo Yang
Modified: 2014-01-28 08:11 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.58 KB, patch)
2012-04-18 23:15 PDT, Leo Yang 		eric: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-04-18 22:49:53 PDT 
AsyncFileSystem::openFileSystem should take more parameters (SecurityOrigin and file system size) from LocalFileSystem::requestFileSystem. These parameter are required when opening a filesystem.
Comment 1 Leo Yang 2012-04-18 23:15:40 PDT 
Created attachment 137850 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-19 16:16:53 PDT 
Comment on attachment 137850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137850&action=review

> Source/WebCore/platform/AsyncFileSystem.cpp:67
> +void AsyncFileSystem::openFileSystem(ScriptExecutionContext*, const String& basePath, const String& storageIdentifier, Type type, long long, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

ScriptExecutationContext is not a platofrm concept.  I believe this is a layering violation.

> Source/WebCore/platform/gtk/AsyncFileSystemGtk.cpp:50
> +void AsyncFileSystem::openFileSystem(SecurityOrigin*, const String& basePath, const String& storageIdentifier, Type type, long long, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

Similarly, I believe this to be a layering violation.