Bug 84305 – [chromium] Plumb a compositor surface ready notification through to the threaded compositor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Plumb a compositor surface ready notification through to the threaded compositor

[James Robinson]

Created attachment 137809 [details]
Patch

[James Robinson]

https://chromiumcodereview.appspot.com/10095021/ has to land before this can thanks to render_widget_fullscreen_pepper

[James Robinson]

Created attachment 137813 [details]
rebased

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 137813 [details]
rebased

Attachment 137813 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12438090

New failing tests:
CCLayerTreeHostTestSetNeedsAnimateInsideAnimationCallback.runMultiThread
CCLayerTreeHostTestAtomicCommit.runMultiThread
CCLayerTreeHostTestSetVisible.runMultiThread
CCLayerTreeHostTestCompositeAndReadbackWhileInvisible.runMultiThread
CCLayerTreeHostTestCommit.runTest
CCLayerTreeHostTestOpacityChange.runMultiThread
CCLayerTreeHostTestStartPageScaleAnimation.runTest
CCLayerTreeHostTestFractionalScroll.runMultiThread
CCLayerTreeHostTestSetRepeatedLostContext.runMultiThread
CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
CCLayerTreeHostTestSetNeedsRedraw.runMultiThread
CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread
CCLayerTreeHostTestAddAnimation.runMultiThread
CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runMultiThread
CCLayerTreeHostTestSetNeedsCommit2.runMultiThread
CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread
CCLayerTreeHostTestSetSingleLostContext.runMultiThread
CCLayerTreeHostTestCommitingWithContinuousRedraw.runMultiThread

[WebKit Review Bot]

Created attachment 137824 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Nat Duca]

Comment on attachment 137813 [details]
rebased

Looks good.

[James Robinson]

(In reply to comment #5)
> (From update of attachment 137813 [details])
> Attachment 137813 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12438090
> 
> New failing tests:
> CCLayerTreeHostTestSetNeedsAnimateInsideAnimationCallback.runMultiThread
> CCLayerTreeHostTestAtomicCommit.runMultiThread
> CCLayerTreeHostTestSetVisible.runMultiThread
> CCLayerTreeHostTestCompositeAndReadbackWhileInvisible.runMultiThread
> CCLayerTreeHostTestCommit.runTest
> CCLayerTreeHostTestOpacityChange.runMultiThread
> CCLayerTreeHostTestStartPageScaleAnimation.runTest
> CCLayerTreeHostTestFractionalScroll.runMultiThread
> CCLayerTreeHostTestSetRepeatedLostContext.runMultiThread
> CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
> CCLayerTreeHostTestSetNeedsRedraw.runMultiThread
> CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread
> CCLayerTreeHostTestAddAnimation.runMultiThread
> CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread
> CCLayerTreeHostTestSynchronizeAnimationStartTimes.runMultiThread
> CCLayerTreeHostTestSetNeedsCommit2.runMultiThread
> CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread
> CCLayerTreeHostTestSetSingleLostContext.runMultiThread
> CCLayerTreeHostTestCommitingWithContinuousRedraw.runMultiThread

Oh whoops, I changed the CCLayerTreeHost contract to require calling setSurfaceReady() before it draws anything, and I didn't update these unit tests to set that.  I guess we learned who forgot to run unit tests before uploading their patch today!

Will fix.

[James Robinson]

Created attachment 137831 [details]
Patch

[James Robinson]

Comment on attachment 137831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137831&action=review

> Source/WebKit/chromium/src/WebViewImpl.h:758
> +    bool m_compositorSurfaceReady;

whoops, i forgot to initialize this bool in the c'tor. will update

[James Robinson]

Created attachment 138010 [details]
initialize new bool in WebViewImpl ctor

[Adrienne Walker]

Comment on attachment 138010 [details]
initialize new bool in WebViewImpl ctor

R=me.

[WebKit Review Bot]

Comment on attachment 138010 [details]
initialize new bool in WebViewImpl ctor

Clearing flags on attachment: 138010

Committed r114800: <http://trac.webkit.org/changeset/114800>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.