[chromium] Plumb a compositor surface ready notification through to the threaded compositor
Created attachment 137809 [details] Patch
https://chromiumcodereview.appspot.com/10095021/ has to land before this can thanks to render_widget_fullscreen_pepper
Created attachment 137813 [details] rebased
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 137813 [details] rebased Attachment 137813 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12438090 New failing tests: CCLayerTreeHostTestSetNeedsAnimateInsideAnimationCallback.runMultiThread CCLayerTreeHostTestAtomicCommit.runMultiThread CCLayerTreeHostTestSetVisible.runMultiThread CCLayerTreeHostTestCompositeAndReadbackWhileInvisible.runMultiThread CCLayerTreeHostTestCommit.runTest CCLayerTreeHostTestOpacityChange.runMultiThread CCLayerTreeHostTestStartPageScaleAnimation.runTest CCLayerTreeHostTestFractionalScroll.runMultiThread CCLayerTreeHostTestSetRepeatedLostContext.runMultiThread CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread CCLayerTreeHostTestSetNeedsRedraw.runMultiThread CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread CCLayerTreeHostTestAddAnimation.runMultiThread CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread CCLayerTreeHostTestSynchronizeAnimationStartTimes.runMultiThread CCLayerTreeHostTestSetNeedsCommit2.runMultiThread CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread CCLayerTreeHostTestSetSingleLostContext.runMultiThread CCLayerTreeHostTestCommitingWithContinuousRedraw.runMultiThread
Created attachment 137824 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 137813 [details] rebased Looks good.
(In reply to comment #5) > (From update of attachment 137813 [details]) > Attachment 137813 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12438090 > > New failing tests: > CCLayerTreeHostTestSetNeedsAnimateInsideAnimationCallback.runMultiThread > CCLayerTreeHostTestAtomicCommit.runMultiThread > CCLayerTreeHostTestSetVisible.runMultiThread > CCLayerTreeHostTestCompositeAndReadbackWhileInvisible.runMultiThread > CCLayerTreeHostTestCommit.runTest > CCLayerTreeHostTestOpacityChange.runMultiThread > CCLayerTreeHostTestStartPageScaleAnimation.runTest > CCLayerTreeHostTestFractionalScroll.runMultiThread > CCLayerTreeHostTestSetRepeatedLostContext.runMultiThread > CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread > CCLayerTreeHostTestSetNeedsRedraw.runMultiThread > CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread > CCLayerTreeHostTestAddAnimation.runMultiThread > CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread > CCLayerTreeHostTestSynchronizeAnimationStartTimes.runMultiThread > CCLayerTreeHostTestSetNeedsCommit2.runMultiThread > CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread > CCLayerTreeHostTestSetSingleLostContext.runMultiThread > CCLayerTreeHostTestCommitingWithContinuousRedraw.runMultiThread Oh whoops, I changed the CCLayerTreeHost contract to require calling setSurfaceReady() before it draws anything, and I didn't update these unit tests to set that. I guess we learned who forgot to run unit tests before uploading their patch today! Will fix.
Created attachment 137831 [details] Patch
Comment on attachment 137831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137831&action=review > Source/WebKit/chromium/src/WebViewImpl.h:758 > + bool m_compositorSurfaceReady; whoops, i forgot to initialize this bool in the c'tor. will update
Created attachment 138010 [details] initialize new bool in WebViewImpl ctor
Comment on attachment 138010 [details] initialize new bool in WebViewImpl ctor R=me.
Comment on attachment 138010 [details] initialize new bool in WebViewImpl ctor Clearing flags on attachment: 138010 Committed r114800: <http://trac.webkit.org/changeset/114800>
All reviewed patches have been landed. Closing bug.