Bug 84305 - [chromium] Plumb a compositor surface ready notification through to the threaded compositor
Summary: [chromium] Plumb a compositor surface ready notification through to the threa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-18 17:35 PDT by James Robinson
Modified: 2012-04-20 16:50 PDT (History)
9 users (show)

See Also:


Attachments
Patch (17.85 KB, patch)
2012-04-18 17:41 PDT, James Robinson
no flags Details | Formatted Diff | Diff
rebased (17.89 KB, patch)
2012-04-18 18:36 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (6.04 MB, application/zip)
2012-04-18 19:51 PDT, WebKit Review Bot
no flags Details
Patch (18.35 KB, patch)
2012-04-18 20:34 PDT, James Robinson
no flags Details | Formatted Diff | Diff
initialize new bool in WebViewImpl ctor (18.64 KB, patch)
2012-04-19 17:21 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-18 17:35:08 PDT
[chromium] Plumb a compositor surface ready notification through to the threaded compositor
Comment 1 James Robinson 2012-04-18 17:41:18 PDT
Created attachment 137809 [details]
Patch
Comment 2 James Robinson 2012-04-18 17:44:24 PDT
https://chromiumcodereview.appspot.com/10095021/ has to land before this can thanks to render_widget_fullscreen_pepper
Comment 3 James Robinson 2012-04-18 18:36:51 PDT
Created attachment 137813 [details]
rebased
Comment 4 WebKit Review Bot 2012-04-18 18:40:25 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 WebKit Review Bot 2012-04-18 19:51:35 PDT
Comment on attachment 137813 [details]
rebased

Attachment 137813 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12438090

New failing tests:
CCLayerTreeHostTestSetNeedsAnimateInsideAnimationCallback.runMultiThread
CCLayerTreeHostTestAtomicCommit.runMultiThread
CCLayerTreeHostTestSetVisible.runMultiThread
CCLayerTreeHostTestCompositeAndReadbackWhileInvisible.runMultiThread
CCLayerTreeHostTestCommit.runTest
CCLayerTreeHostTestOpacityChange.runMultiThread
CCLayerTreeHostTestStartPageScaleAnimation.runTest
CCLayerTreeHostTestFractionalScroll.runMultiThread
CCLayerTreeHostTestSetRepeatedLostContext.runMultiThread
CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
CCLayerTreeHostTestSetNeedsRedraw.runMultiThread
CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread
CCLayerTreeHostTestAddAnimation.runMultiThread
CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runMultiThread
CCLayerTreeHostTestSetNeedsCommit2.runMultiThread
CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread
CCLayerTreeHostTestSetSingleLostContext.runMultiThread
CCLayerTreeHostTestCommitingWithContinuousRedraw.runMultiThread
Comment 6 WebKit Review Bot 2012-04-18 19:51:41 PDT
Created attachment 137824 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Nat Duca 2012-04-18 20:01:15 PDT
Comment on attachment 137813 [details]
rebased

Looks good.
Comment 8 James Robinson 2012-04-18 20:29:59 PDT
(In reply to comment #5)
> (From update of attachment 137813 [details])
> Attachment 137813 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12438090
> 
> New failing tests:
> CCLayerTreeHostTestSetNeedsAnimateInsideAnimationCallback.runMultiThread
> CCLayerTreeHostTestAtomicCommit.runMultiThread
> CCLayerTreeHostTestSetVisible.runMultiThread
> CCLayerTreeHostTestCompositeAndReadbackWhileInvisible.runMultiThread
> CCLayerTreeHostTestCommit.runTest
> CCLayerTreeHostTestOpacityChange.runMultiThread
> CCLayerTreeHostTestStartPageScaleAnimation.runTest
> CCLayerTreeHostTestFractionalScroll.runMultiThread
> CCLayerTreeHostTestSetRepeatedLostContext.runMultiThread
> CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
> CCLayerTreeHostTestSetNeedsRedraw.runMultiThread
> CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread
> CCLayerTreeHostTestAddAnimation.runMultiThread
> CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread
> CCLayerTreeHostTestSynchronizeAnimationStartTimes.runMultiThread
> CCLayerTreeHostTestSetNeedsCommit2.runMultiThread
> CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread
> CCLayerTreeHostTestSetSingleLostContext.runMultiThread
> CCLayerTreeHostTestCommitingWithContinuousRedraw.runMultiThread

Oh whoops, I changed the CCLayerTreeHost contract to require calling setSurfaceReady() before it draws anything, and I didn't update these unit tests to set that.  I guess we learned who forgot to run unit tests before uploading their patch today!

Will fix.
Comment 9 James Robinson 2012-04-18 20:34:08 PDT
Created attachment 137831 [details]
Patch
Comment 10 James Robinson 2012-04-19 16:27:37 PDT
Comment on attachment 137831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137831&action=review

> Source/WebKit/chromium/src/WebViewImpl.h:758
> +    bool m_compositorSurfaceReady;

whoops, i forgot to initialize this bool in the c'tor. will update
Comment 11 James Robinson 2012-04-19 17:21:12 PDT
Created attachment 138010 [details]
initialize new bool in WebViewImpl ctor
Comment 12 Adrienne Walker 2012-04-20 12:01:33 PDT
Comment on attachment 138010 [details]
initialize new bool in WebViewImpl ctor

R=me.
Comment 13 WebKit Review Bot 2012-04-20 16:49:59 PDT
Comment on attachment 138010 [details]
initialize new bool in WebViewImpl ctor

Clearing flags on attachment: 138010

Committed r114800: <http://trac.webkit.org/changeset/114800>
Comment 14 WebKit Review Bot 2012-04-20 16:50:12 PDT
All reviewed patches have been landed.  Closing bug.