RESOLVED FIXED 84302
JSC testing should have complete coverage over typed array types 
https://bugs.webkit.org/show_bug.cgi?id=84302
Summary JSC testing should have complete coverage over typed array types
Filip Pizlo
Reported 2012-04-18 16:58:55 PDT
Patch forthcoming.
Attachments
the patch (786.98 KB, patch)
2012-04-18 17:04 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-04-18 17:04:18 PDT
Created attachment 137805 [details] the patch
Geoffrey Garen
Comment 2 2012-04-18 17:12:31 PDT
Comment on attachment 137805 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=137805&action=review r=me, with a comment below: > LayoutTests/fast/js/script-tests/dfg-uint8array.js:109 > + shouldBe("safeGetter(a, b, c)", "" + safeGetter(checkA, b, c)); Would be nice to put in the actual values of b and c instead of the letters, so it's clearer what went wrong if something goes wrong. > LayoutTests/fast/js/script-tests/dfg-uint8array.js:136 > + shouldBe("getter(a, b, c)", "" + safeGetter(a, b)); Ditto.
Filip Pizlo
Comment 3 2012-04-18 17:16:10 PDT
Landed without Geoff suggestions in: http://trac.webkit.org/changeset/114587 Will land Geoff's suggestions in a separate patch.
Filip Pizlo
Comment 4 2012-04-18 18:12:52 PDT
Landed in http://trac.webkit.org/changeset/114594
Filip Pizlo
Comment 5 2012-04-19 09:24:19 PDT
Landed float64 test support in http://trac.webkit.org/changeset/114639
Note You need to log in before you can comment on or make changes to this bug.