Bug 84297 - FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted
: FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more informa...
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-18 16:06 PST by
Modified: 2012-05-02 19:54 PST (History)


Attachments
Patch (24.73 KB, patch)
2012-04-20 23:19 PST, Jon Honeycutt
buildbot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Patch v2 (26.27 KB, patch)
2012-04-24 17:30 PST, Jon Honeycutt
buildbot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Patch v3 (26.82 KB, patch)
2012-04-24 19:50 PST, Jon Honeycutt
buildbot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Patch v4 (27.92 KB, patch)
2012-04-24 20:28 PST, Jon Honeycutt
aestes: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-18 16:06:01 PST
FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted.
------- Comment #1 From 2012-04-20 23:19:21 PST -------
Created an attachment (id=138222) [details]
Patch
------- Comment #2 From 2012-04-20 23:43:40 PST -------
(From update of attachment 138222 [details])
Attachment 138222 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12476386
------- Comment #3 From 2012-04-24 17:30:47 PST -------
Created an attachment (id=138700) [details]
Patch v2
------- Comment #4 From 2012-04-24 18:45:50 PST -------
(From update of attachment 138700 [details])
Attachment 138700 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12521360
------- Comment #5 From 2012-04-24 19:50:04 PST -------
Created an attachment (id=138721) [details]
Patch v3
------- Comment #6 From 2012-04-24 20:14:01 PST -------
(From update of attachment 138721 [details])
Attachment 138721 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12523449
------- Comment #7 From 2012-04-24 20:28:36 PST -------
Created an attachment (id=138728) [details]
Patch v4
------- Comment #8 From 2012-04-30 15:32:53 PST -------
(From update of attachment 138728 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review

> Source/WebCore/html/HTMLFormElement.h:114
> +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;

FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.
------- Comment #9 From 2012-05-02 19:54:35 PST -------
(In reply to comment #8)
> (From update of attachment 138728 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review
> 
> > Source/WebCore/html/HTMLFormElement.h:114
> > +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;
> 
> FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.

Landed with this change in <http://trac.webkit.org/changeset/115926>.