Bug 84297 – FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jon Honeycutt]

FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted.

[Jon Honeycutt]

Created attachment 138222 [details]
Patch

[Build Bot]

Comment on attachment 138222 [details]
Patch

Attachment 138222 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12476386

[Jon Honeycutt]

Created attachment 138700 [details]
Patch v2

[Build Bot]

Comment on attachment 138700 [details]
Patch v2

Attachment 138700 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12521360

[Jon Honeycutt]

Created attachment 138721 [details]
Patch v3

[Build Bot]

Comment on attachment 138721 [details]
Patch v3

Attachment 138721 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12523449

[Jon Honeycutt]

Created attachment 138728 [details]
Patch v4

[Andy Estes]

Comment on attachment 138728 [details]
Patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review

> Source/WebCore/html/HTMLFormElement.h:114
> +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;

FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.

[Jon Honeycutt]

(In reply to comment #8)
> (From update of attachment 138728 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review
> 
> > Source/WebCore/html/HTMLFormElement.h:114
> > +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;
> 
> FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.

Landed with this change in <http://trac.webkit.org/changeset/115926>.