RESOLVED FIXED 84292
KeywordLookupGenerator.py should take an output file as an argument 
https://bugs.webkit.org/show_bug.cgi?id=84292
Summary KeywordLookupGenerator.py should take an output file as an argument
Don Olmstead
Reported 2012-04-18 15:48:08 PDT
Currently KeywordLookupGenerator.py writes to stdout only. The results are expected to be piped to a separate file when creating KeywordLookup.h. To make the script more friendly to GYP it should take an additional argument which specifies a file to write to.
Attachments
Patch (1.96 KB, patch)
2012-04-19 14:06 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (2.09 KB, patch)
2012-04-19 14:42 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2012-04-19 14:06:38 PDT
Created attachment 137970 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-19 14:16:11 PDT
Comment on attachment 137970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review > Source/JavaScriptCore/KeywordLookupGenerator.py:32 > +if (len(sys.argv) > 2): We should do the argument parsing separately, instead of re-using the args array in two places here. Otherwise seems OK. A hack, but OK.
Eric Seidel (no email)
Comment 3 2012-04-19 14:26:48 PDT
Comment on attachment 137970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review > Source/JavaScriptCore/KeywordLookupGenerator.py:33 > + file_output = open(sys.argv[-1], "w") So I would use output_file_name = sys.argv[2] if len(sys.argsv) > 2 And then check "if output_file_name:"
Don Olmstead
Comment 4 2012-04-19 14:42:46 PDT
Created attachment 137977 [details] Patch
WebKit Review Bot
Comment 5 2012-04-19 15:44:56 PDT
Comment on attachment 137977 [details] Patch Clearing flags on attachment: 137977 Committed r114684: <http://trac.webkit.org/changeset/114684>
WebKit Review Bot
Comment 6 2012-04-19 15:45:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.