Currently KeywordLookupGenerator.py writes to stdout only. The results are expected to be piped to a separate file when creating KeywordLookup.h. To make the script more friendly to GYP it should take an additional argument which specifies a file to write to.
Created attachment 137970 [details] Patch
Comment on attachment 137970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review > Source/JavaScriptCore/KeywordLookupGenerator.py:32 > +if (len(sys.argv) > 2): We should do the argument parsing separately, instead of re-using the args array in two places here. Otherwise seems OK. A hack, but OK.
Comment on attachment 137970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review > Source/JavaScriptCore/KeywordLookupGenerator.py:33 > + file_output = open(sys.argv[-1], "w") So I would use output_file_name = sys.argv[2] if len(sys.argsv) > 2 And then check "if output_file_name:"
Created attachment 137977 [details] Patch
Comment on attachment 137977 [details] Patch Clearing flags on attachment: 137977 Committed r114684: <http://trac.webkit.org/changeset/114684>
All reviewed patches have been landed. Closing bug.