Bug 84286 – Tables with just border-style set on the cells do not get a grid

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Robert Hogan]

Created attachment 137776 [details]
Test Case - There should be a table!

This is because every cell gets a zero-width border in createSharedCellStyle() if the table border is not explictly set. FF and Opera don't do this. We should probably not do anything to the cell's border if there is no table border explicitly set.

[Robert Hogan]

This is related to bug 83978 in a way, but should be fixed separately.

[Robert Hogan]

Created attachment 153336 [details]
Patch

[Julien Chaffraix]

Comment on attachment 153336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153336&action=review

> Source/WebCore/rendering/RenderTreeAsText.cpp:318
> +            BorderValue prevBorder = o.style()->borderTop();

To be frank, our text border dumping is inadequate as it would dump several border configurations in the exact same way. Your change is definitely going in the right direction of dumping more rather than less so you can keep this change or just say that it should go in a list of stuff we will want to change during a let-s-break-the-baselines hackathlon.

[Robert Hogan]

Committed r126683: <http://trac.webkit.org/changeset/126683>