Bug 84285 - IndexedDB: remove IDB(Index|ObjectStore)BackendImpl::get/getKey for IDBKey
Summary: IndexedDB: remove IDB(Index|ObjectStore)BackendImpl::get/getKey for IDBKey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on: 83638
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-18 14:54 PDT by Alec Flett
Modified: 2012-04-23 18:50 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.99 KB, patch)
2012-04-23 14:18 PDT, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-04-18 14:54:03 PDT
once bug 83638 is fixed, we'll be able to remove the backend support for get/getKey with just an IDBKey, since everything is now implemented in terms of an IDBKeyRange
Comment 1 Alec Flett 2012-04-23 14:18:26 PDT
Created attachment 138425 [details]
Patch
Comment 2 Alec Flett 2012-04-23 14:20:17 PDT
This is purely code removal... 

ojan@ - r? cq?
Comment 3 WebKit Review Bot 2012-04-23 14:21:31 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Dimitri Glazkov (Google) 2012-04-23 14:28:52 PDT
Comment on attachment 138425 [details]
Patch

delete code? delicious! Are you sure this won't bomb? :)
Comment 5 WebKit Review Bot 2012-04-23 18:50:24 PDT
Comment on attachment 138425 [details]
Patch

Clearing flags on attachment: 138425

Committed r114981: <http://trac.webkit.org/changeset/114981>
Comment 6 WebKit Review Bot 2012-04-23 18:50:36 PDT
All reviewed patches have been landed.  Closing bug.